Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add CPU Power to System Bridge #80781

Merged
merged 5 commits into from Jun 15, 2023

Conversation

timmo001
Copy link
Contributor

@timmo001 timmo001 commented Oct 22, 2022

Breaking change

Proposed change

Adds CPU Power to System Bridge integration.

Package change:
https://github.com/timmo001/system-bridge/releases/tag/3.4.9

Type of change

  • Dependency upgrade
  • New feature (which adds functionality to an existing integration)

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Contributor

@akx akx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A couple of comments (as part of "review 2 PRs for each one you make")

homeassistant/components/system_bridge/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/system_bridge/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/system_bridge/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/system_bridge/sensor.py Outdated Show resolved Hide resolved
timmo001 added a commit to timmo001/core that referenced this pull request Nov 18, 2022
@timmo001 timmo001 force-pushed the system-bridge-cpu-power branch 2 times, most recently from 57e35ab to 5fd5e17 Compare November 18, 2022 12:43
@timmo001 timmo001 force-pushed the system-bridge-cpu-power branch 2 times, most recently from 33cf621 to 37c9a30 Compare December 27, 2022 13:27
@timmo001 timmo001 marked this pull request as draft March 11, 2023 15:52
@timmo001 timmo001 marked this pull request as ready for review March 11, 2023 15:52
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Mar 14, 2023
@timmo001 timmo001 requested a review from balloob June 13, 2023 14:36
@balloob balloob merged commit 61d260e into home-assistant:dev Jun 15, 2023
51 checks passed
@timmo001 timmo001 deleted the system-bridge-cpu-power branch June 15, 2023 15:36
@github-actions github-actions bot locked and limited conversation to collaborators Jun 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants