Add Overkiz DomesticHotWaterProduction #81538

nyroDev · 2022-11-04T11:08:58Z

Breaking change

Proposed change

Implement Overkiz DomesticHotWaterProduction, a Water Heater entity generic.

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This is a port from Ha-Tahoma entity
Please note that I cannot test it myself.

This PR fixes or closes issue: fixes overkiz integration not complete for Atlantic Heat water device #82148
This PR will also solve problem from commenter here who commented inside another issue
This PR is related to issue:
Link to documentation pull request:

Checklist

The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
The code has been formatted using Black (black --fast homeassistant tests)
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

home-assistant · 2022-11-04T11:09:05Z

Hey there @iMicknl, @vlebourl, @tetienne, mind taking a look at this pull request as it has been labeled with an integration (overkiz) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of overkiz can trigger bot actions by commenting:

@home-assistant close Closes the issue.
@home-assistant rename Awesome new title Change the title of the issue.
@home-assistant reopen Reopen the issue.
@home-assistant unassign overkiz Removes the current integration label and assignees on the issue, add the integration domain after the command.

nyroDev · 2022-11-04T11:10:56Z

@tetienne @iMicknl Update I did from HA-Tahoma:

Add checks for dict return when using .get on select_state

Uses only Water_Entity STATES enabled by HA instead of using custom ones.
-> Not 100% sure about the new mapping I did there.

Add all missings casts and stuff like that to make it works with lint and mypy.

nyroDev · 2022-11-04T20:52:19Z

@tetienne @iMicknl After found this code on Jeedom,
And after this comment

I decided to update how the Domestic Water Heater works to handle more controllable name (the case mentionned by @jncanches was not present)

When controllable name was not know, I use a fallback to the "standard" name.

This code could not be tested by me and I'm not sure if we could find a tester for each controllable name...

let me know what you think about that.

tetienne · 2022-11-05T22:13:54Z

@nyroDev When @iMicknl, @vlebourl and myself rework the legacy tahoma integrations, it was decided to use the widget ui or the ui class which are more generic as they can be common to multiple devices and so ease the maintenance. Previous integration was full of if condition, that you can ease using a dict, but that’s still hard to maintain when new hardware are released.
Here, can you check if all these devices have a common property (widget, class, profile, etc)?

nyroDev · 2022-11-06T10:25:10Z

@nyroDev When @iMicknl, @vlebourl and myself rework the legacy tahoma integrations, it was decided to use the widget ui or the ui class which are more generic as they can be common to multiple devices and so ease the maintenance. Previous integration was full of if condition, that you can ease using a dict, but that’s still hard to maintain when new hardware are released. Here, can you check if all these devices have a common property (widget, class, profile, etc)?

@tetienne According to the previous code, ui Class WaterHeatingSystem and widget DomesticHotWaterProduction could be attached to many different devices.

The only setup exemple I could find in pyoverkiz are :

Both have the same uiclass and widget.

The only name difference is the controllableName

So we can't do what you're suggesting.

What I tried to do in this PR is slighlty better than what was done before:
List only 1 time all ctrollable_name in a dict and map them to custom name to apply same action on differerent controllable name.

What may be done is do this detection regarding available command and/or states.
The problem with this approach will be :
Which command should we use when we face multiples commands do the same?

As an exemple:
io:AtlanticDomesticHotWaterProductionV2_CE_FLAT_C2_IOComponent supports these states:

core:BoostModeDurationState
core:BoostEndDateState
core:BoostStartDateState
io:DHWBoostModeState
core:OperatingModeState with a possible boost value

io:AtlanticDomesticHotWaterProductionV2_CETHI_V4_IOComponent supports these states:

core:BoostModeDurationState
core:OperatingModeState with a possible boost value

How should we detect if the water entity is in boost mode?
Previous code uses io:DHWBoostModeState for flat device, core:OperatingModeState > 0 for CETHI

I implied that if the code was done that way, there was a reason.
So I replicated this here.

The main problem is that we don't have all controllable_name and exemple setup available.

I think this kind of information could may be found in the cozytouch app, but I don't have any of these devices nor the ability to uncompile apk...

Again, I tried to conserve as much as possible the behavior that was previously in ha-tahoma...

fbonelle · 2022-11-06T13:23:09Z

Hello,

Since I migrated from tahoma integration to legacy overkiz, my Hot Water Production Device is not well detected (brand: Thermor - model: Aeromax). May be the following log may help the team implement missing cases ? :

`2022-11-06 14:09:24.333 DEBUG (MainThread) [homeassistant.components.overkiz] The following device has been retrieved. Report an issue if not supported correctly (Device(attributes=States(_states=[]), available=True, enabled=True, label=**, device_url=internal://--5801/pod/0, controllable_name='internal:PodMiniComponent', definition=Definition(commands=CommandDefinitions(_commands=[CommandDefinition(command_name='getName', nparams=0), CommandDefinition(command_name='update', nparams=0), CommandDefinition(command_name='setCountryCode', nparams=1), CommandDefinition(command_name='activateCalendar', nparams=0), CommandDefinition(command_name='deactivateCalendar', nparams=0), CommandDefinition(command_name='refreshPodMode', nparams=0), CommandDefinition(command_name='refreshUpdateStatus', nparams=0), CommandDefinition(command_name='setCalendar', nparams=1), CommandDefinition(command_name='setLightingLedPodMode', nparams=1), CommandDefinition(command_name='setPodLedOff', nparams=0), CommandDefinition(command_name='setPodLedOn', nparams=0)]), states=[StateDefinition(qualified_name='core:ConnectivityState', type='DiscreteState', values=['offline', 'online']), StateDefinition(qualified_name='core:CountryCodeState', type='DataState', values=None), StateDefinition(qualified_name='core:LocalIPv4AddressState', type='DataState', values=None), StateDefinition(qualified_name='core:NameState', type='DataState', values=None), StateDefinition(qualified_name='internal:LastActionConfigButtonState', type='DiscreteState', values=['doublePress', 'longPress', 'simplePress', 'triplePress', 'veryLongPress']), StateDefinition(qualified_name='internal:LightingLedPodModeState', type='ContinuousState', values=None)], widget_name='Pod', ui_class='Pod', qualified_name='internal:PodMiniComponent'), data_properties=None, widget=<UIWidget.POD: 'Pod'>, ui_class=<UIClass.POD: 'Pod'>, states=States(_states=[State(name='core:NameState', type=<DataType.STRING: 3>, value='Box'), State(name='internal:LightingLedPodModeState', type=<DataType.FLOAT: 2>, value=1.0), State(name='core:CountryCodeState', type=<DataType.STRING: 3>, value='FR'), State(name='core:LocalIPv4AddressState', type=<DataType.STRING: 3>, value='192.168.100.124')]), type=<ProductType.ACTUATOR: 1>, place_oid='ab94092c-3f1e-461c-9d05-92f787eea625'))

2022-11-06 14:09:24.334 DEBUG (MainThread) [homeassistant.components.overkiz] The following device has been retrieved. Report an issue if not supported correctly (Device(attributes=States(_states=[]), available=True, enabled=True, label=** (**), device_url=io://--5801/14946082, controllable_name='io:StackComponent', definition=Definition(commands=CommandDefinitions(_commands=[CommandDefinition(command_name='advancedSomfyDiscover', nparams=1), CommandDefinition(command_name='discover1WayController', nparams=2), CommandDefinition(command_name='discoverActuators', nparams=1), CommandDefinition(command_name='discoverSensors', nparams=1), CommandDefinition(command_name='discoverSomfyUnsetActuators', nparams=0), CommandDefinition(command_name='joinNetwork', nparams=0), CommandDefinition(command_name='resetNetworkSecurity', nparams=0), CommandDefinition(command_name='shareNetwork', nparams=0)]), states=[], widget_name='IOStack', ui_class='ProtocolGateway', qualified_name='io:StackComponent'), data_properties=None, widget=<UIWidget.IOSTACK: 'IOStack'>, ui_class=<UIClass.PROTOCOL_GATEWAY: 'ProtocolGateway'>, states=States(_states=[]), type=<ProductType.GATEWAY: 5>, place_oid='ab94092c-3f1e-461c-9d05-92f787eea625'))

2022-11-06 14:09:24.334 DEBUG (MainThread) [homeassistant.components.overkiz] The following device has been retrieved. Report an issue if not supported correctly (Device(attributes=States(_states=[State(name='core:Manufacturer', type=<DataType.STRING: 3>, value='Atlantic Group'), State(name='core:FirmwareRevision', type=<DataType.STRING: 3>, value='681008')]), available=True, enabled=True, label=** **, device_url=io://--5801/6489029#1, controllable_name='io:AtlanticDomesticHotWaterProductionIOComponent', definition=Definition(commands=CommandDefinitions(_commands=[CommandDefinition(command_name='advancedRefresh', nparams=1), CommandDefinition(command_name='delayedStopIdentify', nparams=1), CommandDefinition(command_name='getName', nparams=0), CommandDefinition(command_name='identify', nparams=0), CommandDefinition(command_name='refreshManufacturerName', nparams=0), CommandDefinition(command_name='refreshTargetTemperature', nparams=0), CommandDefinition(command_name='refreshWaterConsumption', nparams=0), CommandDefinition(command_name='setComfortTargetTemperature', nparams=1), CommandDefinition(command_name='setEcoTargetTemperature', nparams=1), CommandDefinition(command_name='setFrostProtectionTargetTemperature', nparams=1), CommandDefinition(command_name='setName', nparams=1), CommandDefinition(command_name='setTargetTemperature', nparams=1), CommandDefinition(command_name='startIdentify', nparams=0), CommandDefinition(command_name='stopIdentify', nparams=0), CommandDefinition(command_name='wink', nparams=1), CommandDefinition(command_name='pairOneWayController', nparams=2), CommandDefinition(command_name='refreshAwayModeDuration', nparams=0), CommandDefinition(command_name='refreshBoostModeDuration', nparams=0), CommandDefinition(command_name='refreshCurrentOperatingMode', nparams=0), CommandDefinition(command_name='refreshDHWCapacity', nparams=0), CommandDefinition(command_name='refreshDHWError', nparams=0), CommandDefinition(command_name='refreshDHWMode', nparams=0), CommandDefinition(command_name='refreshOperatingModeCapabilities', nparams=0), CommandDefinition(command_name='refreshOperatingTime', nparams=0), CommandDefinition(command_name='refreshRateManagement', nparams=0), CommandDefinition(command_name='setAwayModeDuration', nparams=1), CommandDefinition(command_name='setBoostModeDuration', nparams=1), CommandDefinition(command_name='setCurrentOperatingMode', nparams=1), CommandDefinition(command_name='setDHWMode', nparams=1), CommandDefinition(command_name='setHaltedTargetTemperature', nparams=1), CommandDefinition(command_name='setRateManagement', nparams=1), CommandDefinition(command_name='unpairAllOneWayControllers', nparams=0), CommandDefinition(command_name='unpairOneWayController', nparams=2)]), states=[StateDefinition(qualified_name='core:BoostModeDurationState', type='ContinuousState', values=None), StateDefinition(qualified_name='core:ComfortTargetTemperatureState', type='ContinuousState', values=None), StateDefinition(qualified_name='core:DiscreteRSSILevelState', type='DiscreteState', values=['good', 'low', 'normal', 'verylow']), StateDefinition(qualified_name='core:EcoTargetTemperatureState', type='ContinuousState', values=None), StateDefinition(qualified_name='core:FrostProtectionTargetTemperatureState', type='ContinuousState', values=None), StateDefinition(qualified_name='core:HaltedTargetTemperatureState', type='ContinuousState', values=None), StateDefinition(qualified_name='core:ManufacturerNameState', type='DataState', values=None), StateDefinition(qualified_name='core:NameState', type='DataState', values=None), StateDefinition(qualified_name='core:OperatingModeState', type='DiscreteState', values=['antifreeze', 'auto', 'away', 'eco', 'frostprotection', 'manual', 'max', 'normal', 'off', 'on', 'prog', 'program', 'boost']), StateDefinition(qualified_name='core:PriorityLockTimerState', type='ContinuousState', values=None), StateDefinition(qualified_name='core:RSSILevelState', type='ContinuousState', values=None), StateDefinition(qualified_name='core:SecuredPositionTemperatureState', type='ContinuousState', values=None), StateDefinition(qualified_name='core:StatusState', type='DiscreteState', values=['available', 'unavailable']), StateDefinition(qualified_name='core:TargetTemperatureState', type='ContinuousState', values=None), StateDefinition(qualified_name='core:TemperatureState', type='ContinuousState', values=None), StateDefinition(qualified_name='core:VersionState', type='ContinuousState', values=None), StateDefinition(qualified_name='core:WaterConsumptionState', type='ContinuousState', values=None), StateDefinition(qualified_name='io:AwayModeDurationState', type='ContinuousState', values=None), StateDefinition(qualified_name='io:DHWCapacityState', type='ContinuousState', values=None), StateDefinition(qualified_name='io:DHWErrorState', type='DataState', values=None), StateDefinition(qualified_name='io:DHWModeState', type='DiscreteState', values=['autoMode', 'manualEcoActive', 'manualEcoInactive']), StateDefinition(qualified_name='io:ElectricBoosterOperatingTimeState', type='ContinuousState', values=None), StateDefinition(qualified_name='io:HeatPumpOperatingTimeState', type='ContinuousState', values=None), StateDefinition(qualified_name='io:OperatingModeCapabilitiesState', type='DataState', values=None), StateDefinition(qualified_name='io:PriorityLockLevelState', type='DiscreteState', values=['comfortLevel1', 'comfortLevel2', 'comfortLevel3', 'comfortLevel4', 'environmentProtection', 'humanProtection', 'userLevel1', 'userLevel2']), StateDefinition(qualified_name='io:PriorityLockOriginatorState', type='DiscreteState', values=['LSC', 'SAAC', 'SFC', 'UPS', 'externalGateway', 'localUser', 'myself', 'rain', 'security', 'temperature', 'timer', 'user', 'wind']), StateDefinition(qualified_name='io:RateManagementState', type='DiscreteState', values=['forbidden', 'no', 'recommended', 'unsuitable', 'wanted'])], widget_name='DomesticHotWaterProduction', ui_class='WaterHeatingSystem', qualified_name='io:AtlanticDomesticHotWaterProductionIOComponent'), data_properties=None, widget=<UIWidget.DOMESTIC_HOT_WATER_PRODUCTION: 'DomesticHotWaterProduction'>, ui_class=<UIClass.WATER_HEATING_SYSTEM: 'WaterHeatingSystem'>, states=States(_states=[State(name='core:NameState', type=<DataType.STRING: 3>, value='DHWP Actuator'), State(name='core:VersionState', type=<DataType.STRING: 3>, value='36383130303820202020'), State(name='core:PriorityLockTimerState', type=<DataType.INTEGER: 1>, value=0), State(name='core:StatusState', type=<DataType.STRING: 3>, value='available'), State(name='core:DiscreteRSSILevelState', type=<DataType.STRING: 3>, value='normal'), State(name='core:RSSILevelState', type=<DataType.FLOAT: 2>, value=74.0), State(name='core:TemperatureState', type=<DataType.FLOAT: 2>, value=51.5), State(name='io:RateManagementState', type=<DataType.STRING: 3>, value='?'), State(name='io:OperatingModeCapabilitiesState', type=<DataType.JSON_OBJECT: 11>, value={'relaunch': 1, 'absence': 1, 'rate_management': 0, 'energy_demand_status': 1}), State(name='core:OperatingModeState', type=<DataType.JSON_OBJECT: 11>, value={'relaunch': 'Keep_Current_Value ', 'absence': 'Keep_Current_Value'}), State(name='core:WaterConsumptionState', type=<DataType.INTEGER: 1>, value=417), State(name='io:DHWErrorState', type=<DataType.JSON_OBJECT: 11>, value={'code': 0, 'family': 'W', 'type': 0}), State(name='io:HeatPumpOperatingTimeState', type=<DataType.INTEGER: 1>, value=8160), State(name='io:ElectricBoosterOperatingTimeState', type=<DataType.INTEGER: 1>, value=295), State(name='io:DHWModeState', type=<DataType.STRING: 3>, value='manualEcoActive'), State(name='core:TargetTemperatureState', type=<DataType.FLOAT: 2>, value=54.0), State(name='core:BoostModeDurationState', type=<DataType.INTEGER: 1>, value=0), State(name='io:AwayModeDurationState', type=<DataType.STRING: 3>, value='0'), State(name='core:ManufacturerNameState', type=<DataType.STRING: 3>, value='Thermor')]), type=<ProductType.ACTUATOR: 1>, place_oid='ab94092c-3f1e-461c-9d05-92f787eea625'))

2022-11-06 14:09:24.336 DEBUG (MainThread) [homeassistant.components.overkiz] The following device has been retrieved. Report an issue if not supported correctly (Device(attributes=States(_states=[State(name='core:Manufacturer', type=<DataType.STRING: 3>, value='Atlantic Group'), State(name='core:FirmwareRevision', type=<DataType.STRING: 3>, value='681008'), State(name='core:PowerSourceType', type=<DataType.STRING: 3>, value='mainSupply'), State(name='core:MeasuredValueType', type=<DataType.STRING: 3>, value='core:ElectricalEnergyInWh')]), available=True, enabled=True, label=** (#), device_url=io://--5801/6489029#2, controllable_name='io:DHWCumulatedElectricalEnergyConsumptionIOSystemDeviceSensor', definition=Definition(commands=CommandDefinitions(_commands=[CommandDefinition(command_name='refreshElectricEnergyConsumption', nparams=0)]), states=[StateDefinition(qualified_name='core:ConsumptionTariff0State', type='ContinuousState', values=None), StateDefinition(qualified_name='core:ConsumptionTariff1State', type='ContinuousState', values=None), StateDefinition(qualified_name='core:ConsumptionTariff2State', type='ContinuousState', values=None), StateDefinition(qualified_name='core:ConsumptionTariff3State', type='ContinuousState', values=None), StateDefinition(qualified_name='core:ConsumptionTariff4State', type='ContinuousState', values=None), StateDefinition(qualified_name='core:ConsumptionTariff5State', type='ContinuousState', values=None), StateDefinition(qualified_name='core:ConsumptionTariff6State', type='ContinuousState', values=None), StateDefinition(qualified_name='core:ConsumptionTariff7State', type='ContinuousState', values=None), StateDefinition(qualified_name='core:ConsumptionTariff8State', type='ContinuousState', values=None), StateDefinition(qualified_name='core:ConsumptionTariff9State', type='ContinuousState', values=None), StateDefinition(qualified_name='core:ElectricEnergyConsumptionState', type='ContinuousState', values=None), StateDefinition(qualified_name='core:StatusState', type='DiscreteState', values=['available', 'unavailable'])], widget_name='CumulativeElectricPowerConsumptionSensor', ui_class='ElectricitySensor', qualified_name='io:DHWCumulatedElectricalEnergyConsumptionIOSystemDeviceSensor'), data_properties=None, widget=<UIWidget.CUMULATIVE_ELECTRIC_POWER_CONSUMPTION_SENSOR: 'CumulativeElectricPowerConsumptionSensor'>, ui_class=<UIClass.ELECTRICITY_SENSOR: 'ElectricitySensor'>, states=States(_states=[State(name='core:StatusState', type=<DataType.STRING: 3>, value='available'), State(name='core:ElectricEnergyConsumptionState', type=<DataType.INTEGER: 1>, value=3968574)]), type=<ProductType.SENSOR: 2>, place_oid='ab94092c-3f1e-461c-9d05-92f787eea625'))`

Regards

nyroDev · 2022-11-06T20:13:23Z

Thanks @fbonelle, it does help.
You're device controllable_name is io:AtlanticDomesticHotWaterProductionIOComponent, which I added on this PR
Could you tell me if your device was working correctly with the old integration Ha-Tahoma?
As far as I can tell, the boost mode was not detected correctly

@tetienne I'll rewrite everything to detect existing states/command, it could works better I think.

@fbonelle I'll let you know when you could test this PR.

tetienne · 2022-11-06T20:38:51Z

@nyroDev I checked at the code on ha-tahoma, and was not aware we were using the controllable name. Sorry for my previous comment as you just tried to backport our code.

Perhaps have a look to my WIP PR about using CoverEntityDescription. It can give you some ideas to ease your code with ClimateEntityDescription

fbonelle · 2022-11-06T20:52:09Z

Thanks @fbonelle, it does help. You're device controllable_name is io:AtlanticDomesticHotWaterProductionIOComponent, which I added on this PR Could you tell me if your device was working correctly with the old integration Ha-Tahoma? As far as I can tell, the boost mode was not detected correctly

@tetienne I'll rewrite everything to detect existing states/command, it could works better I think.

@fbonelle I'll let you know when you could test this PR.

Hello,

It was not working at 100%.

Was missing boost mode (and I guess the economic mode). I have just checked what the cozytouch application can do:

Automatic mode
Economic mode
Manual mode
Boost (and asking how many days in boost mode)

A really newby question: how do I test the pull request ? ;)

Regards

iMicknl · 2022-11-16T10:30:35Z

@nyroDev I found another user in case you need more testers. #82148

…tion

nyroDev · 2022-11-16T23:15:19Z

@iMicknl @tetienne I updated the whole code in order to detect which command/states are available.
After reviewing the 3 differents devices setup I got, it should work, at least on paper...
After you checked the code, the next step will be to test it out with real user if possible...

Quentame

Some questions but good overall

homeassistant/components/overkiz/water_heater_entities/domestic_hot_water_production.py

…c_hot_water_production.py Co-authored-by: Quentame <polletquentin74@me.com>

nyroDev · 2022-11-20T21:25:47Z

@jncanches and @MassimoL06 it could be great if you could test it, this PR should fix your overkiz integration with your respective water heater.

homeassistant/components/overkiz/water_heater_entities/domestic_hot_water_production.py

…tion

homeassistant/components/overkiz/water_heater_entities/domestic_hot_water_production.py

…tion

Quentame

LGTM

Discussed with @iMicknl @nyroDev : PR is ready and user feedback will be welcomed.

MartinHjelmare

Please address the comment in a new PR. Thanks!

MartinHjelmare · 2022-11-30T03:26:18Z

homeassistant/components/overkiz/water_heater_entities/domestic_hot_water_production.py

+            return
+
+        if self._is_boost_mode_on:
+            # We're setting a non Boost mode and the device is currently in Boost mode, the following code remove all boost operations


Please break long comments around 88 characters per line.

Port DomesticHotWaterProduction from HA-Tahoma

2d3ffd4

home-assistant bot added cla-signed integration: overkiz new-feature Quality Scale: No score labels Nov 4, 2022

nyroDev mentioned this pull request Nov 4, 2022

Regression - Overkiz Integration with Cozytouch hub - Only temperature and Energy comsuption supported , "heatingsystem" device not supported #80375

Closed

Quentame self-assigned this Nov 4, 2022

Add new domestic hot water controllable_name

6bf9553

nyroDev added 2 commits November 16, 2022 22:20

Merge branch 'home-assistant:dev' into overkiz/domesticHotWaterProduc…

28ed668

…tion

Update DHWP to detect existing commands instead of devices

e14172a

Quentame requested changes Nov 18, 2022

View reviewed changes

Quentame reviewed Nov 19, 2022

View reviewed changes

homeassistant/components/overkiz/water_heater_entities/domestic_hot_water_production.py Outdated Show resolved Hide resolved

nyroDev and others added 5 commits November 19, 2022 15:52

Update homeassistant/components/overkiz/water_heater_entities/domesti…

f74939a

…c_hot_water_production.py Co-authored-by: Quentame <polletquentin74@me.com>

Update homeassistant/components/overkiz/water_heater_entities/domesti…

23904ca

…c_hot_water_production.py Co-authored-by: Quentame <polletquentin74@me.com>

Improve read states and comment for overkiz DHWP

43e5aa8

Remove DHWP_BOOST_MODES

0b5ba9c

Update DHWP to handle more device correctly

cfd1588

nyroDev mentioned this pull request Nov 20, 2022

Add missings commands and states for modbuslink:AtlanticDomesticHotWaterProductionMBLComponent iMicknl/python-overkiz-api#678

Merged

Improve current_temperature for bogus device

f6ff358

iMicknl reviewed Nov 20, 2022

View reviewed changes

homeassistant/components/overkiz/water_heater_entities/domestic_hot_water_production.py Outdated Show resolved Hide resolved

nyroDev added 4 commits November 20, 2022 23:05

Init overkiz_to_operation_mode for DHWP

29d52ef

Update command to be correct

d842707

Merge branch 'home-assistant:dev' into overkiz/domesticHotWaterProduc…

bba33c5

…tion

Merge branch 'home-assistant:dev' into overkiz/domesticHotWaterProduc…

367ed90

…tion

iMicknl reviewed Nov 27, 2022

View reviewed changes

homeassistant/components/overkiz/water_heater_entities/domestic_hot_water_production.py Outdated Show resolved Hide resolved

nyroDev and others added 5 commits November 28, 2022 00:12

Upgrade pyoverkiz and use new constants for DHWP

3ffb1ad

Remove .tow/.package.lock

236ed21

Merge branch 'home-assistant:dev' into overkiz/domesticHotWaterProduc…

ec9abb6

…tion

Merge branch 'dev' into overkiz/domesticHotWaterProduction

fde4675

Merge branch 'dev' into overkiz/domesticHotWaterProduction

81927a0

Quentame approved these changes Nov 29, 2022

View reviewed changes

Quentame merged commit 73cd263 into home-assistant:dev Nov 29, 2022

Quentame mentioned this pull request Nov 29, 2022

Migrate ha-tahoma to Overkiz integration in core iMicknl/ha-tahoma#697

Closed

63 tasks

nyroDev deleted the overkiz/domesticHotWaterProduction branch November 29, 2022 23:29

MartinHjelmare reviewed Nov 30, 2022

View reviewed changes

github-actions bot locked and limited conversation to collaborators Dec 1, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Overkiz DomesticHotWaterProduction #81538

Add Overkiz DomesticHotWaterProduction #81538

nyroDev commented Nov 4, 2022 •

edited

home-assistant bot commented Nov 4, 2022

nyroDev commented Nov 4, 2022

nyroDev commented Nov 4, 2022

tetienne commented Nov 5, 2022

nyroDev commented Nov 6, 2022

fbonelle commented Nov 6, 2022 •

edited

nyroDev commented Nov 6, 2022

tetienne commented Nov 6, 2022

fbonelle commented Nov 6, 2022 •

edited

iMicknl commented Nov 16, 2022

nyroDev commented Nov 16, 2022

Quentame left a comment

nyroDev commented Nov 20, 2022

Quentame left a comment

MartinHjelmare left a comment

MartinHjelmare Nov 30, 2022

nyroDev Nov 30, 2022

Add Overkiz DomesticHotWaterProduction #81538

Add Overkiz DomesticHotWaterProduction #81538

Conversation

nyroDev commented Nov 4, 2022 • edited

Breaking change

Proposed change

Type of change

Additional information

Checklist

home-assistant bot commented Nov 4, 2022

nyroDev commented Nov 4, 2022

nyroDev commented Nov 4, 2022

tetienne commented Nov 5, 2022

nyroDev commented Nov 6, 2022

fbonelle commented Nov 6, 2022 • edited

nyroDev commented Nov 6, 2022

tetienne commented Nov 6, 2022

fbonelle commented Nov 6, 2022 • edited

iMicknl commented Nov 16, 2022

nyroDev commented Nov 16, 2022

Quentame left a comment

Choose a reason for hiding this comment

nyroDev commented Nov 20, 2022

Quentame left a comment

Choose a reason for hiding this comment

MartinHjelmare left a comment

Choose a reason for hiding this comment

MartinHjelmare Nov 30, 2022

Choose a reason for hiding this comment

nyroDev Nov 30, 2022

Choose a reason for hiding this comment

nyroDev commented Nov 4, 2022 •

edited

fbonelle commented Nov 6, 2022 •

edited

fbonelle commented Nov 6, 2022 •

edited