Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump dbus-fast to 1.71.0 #81541

Merged
merged 1 commit into from Nov 4, 2022
Merged

Bump dbus-fast to 1.71.0 #81541

merged 1 commit into from Nov 4, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 4, 2022

Proposed change

performance improvements

changelog: Bluetooth-Devices/dbus-fast@v1.67.0...v1.71.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@MartinHjelmare MartinHjelmare merged commit ca905a8 into dev Nov 4, 2022
@MartinHjelmare MartinHjelmare deleted the dbus_71 branch November 4, 2022 14:29
@bdraco
Copy link
Member Author

bdraco commented Nov 4, 2022

Thanks. Each performance improvement makes this more reliable. As we have separate connections for the client and the service data if the scanner stream gets too far behind the client connects all fail because they can’t be resolved in time.

Still need to optimize the reception of the gatt services but getting to the point where it doesn’t ever fail anymore because it hits the timeout when the stream is so far behind.

@github-actions github-actions bot locked and limited conversation to collaborators Nov 5, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants