Plex: Add exception handler when connection fails #8179
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@abmantis, thanks for your PR! By analyzing the history of the files in this pull request, we identified @JesseWebDotCom, @fabaff and @tomduijf to be potential reviewers. |
rytilahti
reviewed
Jun 24, 2017
| @@ -145,6 +145,10 @@ def update_devices(): | |||
| _LOGGER.error("Could not connect to plex server at http://%s", | |||
| host) | |||
| return | |||
| except requests.exceptions.ConnectionError: | |||
| _LOGGER.error("Could not connect to plex server at http://%s", | |||
| host) | |||
There was a problem hiding this comment.
You might want to consider catching RequestException, see http://docs.python-requests.org/en/latest/user/quickstart/#errors-and-exceptions .
Other than that, I'd recommend using except .. as:
except X as ex:
_LOGGER.error("asdf: %s" % ex)
to give a hint to the user about what type of error happened.
balloob
reviewed
Jun 27, 2017
| @@ -145,6 +145,10 @@ def update_devices(): | |||
| _LOGGER.error("Could not connect to plex server at http://%s", | |||
| host) | |||
| return | |||
| except requests.exceptions.RequestException as ex: | |||
There was a problem hiding this comment.
I think that you should remove the catching of OSError, because that never happens.
|
Any plans to finish this PR? |
|
Yes. I'll probably be able to get back to this later today or tomorrow. |
abmantis
force-pushed
the
plex_no_connection_handle
branch
from
8ee139a
to
1781538
Compare
|
Bueno 🐬 |
Merged
dethpickle
pushed a commit
to dethpickle/home-assistant
that referenced
this pull request
Aug 18, 2017
* add exception handler when connection fails * plex: improve exception handling * remove uneeded exception handler
ghost
added
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description:
Add exception handler for when the connection fails (server is down).
If the code does not interact with devices:
toxrun successfully. Your PR cannot be merged unless tests pass