New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Use IntFlag for EntityFeature #81903
Conversation
Is it worth doing this by platform so we can also change the type hints that use |
I was planning further tweaks in a follow-up PR (pylint and individual components). |
I normally try to avoid adjusting components at the same time as platform, as it makes it harder to review |
@uvjustin I actually revert the type hints for now, to keep this PR smaller. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, Thanks @epenet 👍
Proposed change
Replace
IntEnum
withIntFlag
for***EntityFeature
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: