Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use IntFlag for EntityFeature #81903

Merged
merged 8 commits into from Nov 16, 2022
Merged

Conversation

epenet
Copy link
Contributor

@epenet epenet commented Nov 10, 2022

Proposed change

Replace IntEnum with IntFlag for ***EntityFeature

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@epenet epenet marked this pull request as ready for review November 10, 2022 14:28
@epenet epenet requested review from a team and raman325 as code owners November 10, 2022 14:28
@epenet epenet removed the small-pr PRs with less than 30 lines. label Nov 15, 2022
@uvjustin
Copy link
Contributor

Is it worth doing this by platform so we can also change the type hints that use int in the individual components?

@epenet
Copy link
Contributor Author

epenet commented Nov 15, 2022

I was planning further tweaks in a follow-up PR (pylint and individual components).
There are so many components to adjust that I think it's better to not adjust components at the same time as the base platform.

@epenet epenet marked this pull request as draft November 16, 2022 10:23
@epenet epenet marked this pull request as ready for review November 16, 2022 10:33
@epenet
Copy link
Contributor Author

epenet commented Nov 16, 2022

Is it worth doing this by platform so we can also change the type hints that use int in the individual components?

I normally try to avoid adjusting components at the same time as platform, as it makes it harder to review

@epenet
Copy link
Contributor Author

epenet commented Nov 16, 2022

@uvjustin I actually revert the type hints for now, to keep this PR smaller.
We can look at the type hints in a follow-up PR.

@epenet epenet added the small-pr PRs with less than 30 lines. label Nov 16, 2022
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, Thanks @epenet 👍

@frenck frenck merged commit a91abeb into home-assistant:dev Nov 16, 2022
@epenet epenet deleted the intflag-entity-feature branch November 16, 2022 11:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants