Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move bluetooth remote scanner implementation into a base class #82012

Merged
merged 7 commits into from Nov 13, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 13, 2022

Proposed change

Move remote bluetooth remote scanner implementation into a base class and
add test coverage for it.

In a future PR models.py will be split into multiple files after
home-assistant-libs/home-assistant-bluetooth#10

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

- The same implementation can be reused for other remotes
  such as shelly in home-assistant#82007
@home-assistant
Copy link

Hey there @OttoWinter, @jesserockz, mind taking a look at this pull request as it has been labeled with an integration (esphome) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of esphome can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign esphome Removes the current integration label and assignees on the issue, add the integration domain after the command.

@bdraco
Copy link
Member Author

bdraco commented Nov 13, 2022

I think this will be easier to manage if we move it into base_scanner.py

@bdraco
Copy link
Member Author

bdraco commented Nov 13, 2022

home-assistant-libs/home-assistant-bluetooth#10 is needed first before we can split up this file to avoid a circular import

@bdraco
Copy link
Member Author

bdraco commented Nov 13, 2022

I'll write the test in test_models.py and we can rearrange it in another PR after home-assistant-libs/home-assistant-bluetooth#10 merges and is bumped

@bdraco bdraco marked this pull request as ready for review November 13, 2022 04:40
@bdraco
Copy link
Member Author

bdraco commented Nov 13, 2022

Retested with esphome and the new shelly scanner 👍

@bdraco bdraco changed the title Move remote bluetooth remote scanner implementation into a base class Move bluetooth remote scanner implementation into a base class Nov 13, 2022
@bdraco
Copy link
Member Author

bdraco commented Nov 13, 2022

Thanks.

@bdraco bdraco merged commit f584efa into home-assistant:dev Nov 13, 2022
@bdraco bdraco deleted the remote_scanner_base_class branch November 13, 2022 20:18
@github-actions github-actions bot locked and limited conversation to collaborators Nov 14, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants