New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move bluetooth remote scanner implementation into a base class #82012
Conversation
- The same implementation can be reused for other remotes such as shelly in home-assistant#82007
Hey there @OttoWinter, @jesserockz, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
I think this will be easier to manage if we move it into base_scanner.py |
home-assistant-libs/home-assistant-bluetooth#10 is needed first before we can split up this file to avoid a circular import |
I'll write the test in test_models.py and we can rearrange it in another PR after home-assistant-libs/home-assistant-bluetooth#10 merges and is bumped |
Retested with esphome and the new shelly scanner 👍 |
Thanks. |
Proposed change
Move remote bluetooth remote scanner implementation into a base class and
add test coverage for it.
In a future PR
models.py
will be split into multiple files afterhome-assistant-libs/home-assistant-bluetooth#10
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: