New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Configure autoflake for pre-commit #82414
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
akx
requested review from
Jc2k,
Ernst79,
emontnemery,
cgtobi,
a team and
bdraco
as code owners
November 20, 2022 14:51
home-assistant
bot
added
cla-signed
code-quality
core
has-tests
small-pr
PRs with less than 30 lines.
labels
Nov 20, 2022
frenck
reviewed
Nov 21, 2022
balloob
reviewed
Nov 21, 2022
frenck
approved these changes
Nov 22, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @akx 👍
What’s the benefit of autoflake while we also use Black ? |
It cleans up unused imports (that is basically all it does). Not much more (so it doesn't do the full flake8 suite, as the name implies). |
aidengindin
pushed a commit
to aidengindin/core
that referenced
this pull request
Nov 22, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This PR configures the autoflake linter in the pre-commit configuration and runs it. (I checked with
git log -S autoflake
that this hadn't been considered before.)The main benefit is that
autoflake
can clean up unused imports and variables that other linters down the line would complain about.Type of change
Checklist
black --fast homeassistant tests
)To help with the load of incoming pull requests: