Revert "Add dynamic generation of device triggers from keypad buttons #80797"

[bdraco]

Proposed change

I tried to figure out a way to rework this but it since #80797 requires the integration to be setup to attach the trigger its not going to work if the integration isn't setup in time or is in a failed/retry state.

I think we are going to have to rework that design to rely only what is in the device registry when attaching triggers.

I hate to do a revert of #80797 but since it causes pico remotes to no longer function if the bridge isn't available right away at startup or ends up in retry at startup as reported in #82495 & #81999 I don't think we have another option.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes Caseta Pico remote automations failing since 2022.11 #82495 & fixes Lutron Pico triggers can't be applied - Automation Error #81999
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[home-assistant]

Hey there @swails, @danaues, mind taking a look at this pull request as it has been labeled with an integration (lutron_caseta) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of lutron_caseta can trigger bot actions by commenting:

• @home-assistant close Closes the issue.
• @home-assistant rename Awesome new title Change the title of the issue.
• @home-assistant reopen Reopen the issue.
• @home-assistant unassign lutron_caseta Removes the current integration label and assignees on the issue, add the integration domain after the command.

[bdraco]

@danaues Sorry about doing a revert. Let me know if you have see another way.

[danaues]

@bdraco,

Is there an async call that we can await , so it happens right when the integration is set up?

    _async_register_bridge_device(hass, entry_id, bridge_device, bridge)
    keypad_data = _async_setup_keypads(hass, entry_id, bridge, bridge_device)

[danaues]

Have you tested with the revert to confirm that it fixes the issue? I don't see anything that should make this slower that the original. Not waiting on any extra calls from the bridge, just looping through some dicts.

[bdraco]

@bdraco,

Is there an async call that we can await , so it happens right when the integration is set up?

    _async_register_bridge_device(hass, entry_id, bridge_device, bridge)

    keypad_data = _async_setup_keypads(hass, entry_id, bridge, bridge_device)

That would work unless the integration fails to setup in which case it would deadlock setting up automations. We could add a timeout but that gets us back to the same failure state where the integration isn't setup yet.

[bdraco]

Have you tested with the revert to confirm that it fixes the issue?

Yes. I added an explicit test as well to make sure it can still attach triggers if the integration is slow to setup, failed, or retrying by unloading the integration and making sure the triggers still attach

I don't see anything that should make this slower that the original. Not waiting on any extra calls from the bridge, just looping through some dicts.

The original didn't require the integration to be setup to attach the triggers which is the core issue here. We can't be sure it will be completed setup at attach time

[bdraco]

I was digging into the device triggers to see if we can do some type of late attach but I haven't finished going through it yet because of the holiday

[bdraco]

The validation can handle the config entry not being loaded yet

core/homeassistant/components/device_automation/trigger.py

Line 57 in 35dbc31

async def async_validate_trigger_config(

But attaching the trigger can't because thats the point where the automation is being setup

core/homeassistant/components/device_automation/trigger.py

Line 93 in 35dbc31

async def async_attach_trigger(

[bdraco]

This is a bit of a problem since if you rename the button the trigger breaks

[elupus]

We do late attach in the new PluggableActions

[bdraco]

We do late attach in the new PluggableActions

This one is getting replaced with #82714