Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump bluetooth-auto-recovery to 0.5.2 #82768

Merged
merged 5 commits into from Nov 27, 2022

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Nov 27, 2022

Proposed change

Implements the generic usb reset in user space since the kernel will take a long time to get it:
https://lore.kernel.org/netdev/20221006170915.v3.1.I46e98b47be875d0b9abff2d19417c612077d1909@changeid/T/

changelog: Bluetooth-Devices/bluetooth-auto-recovery@v0.4.0...v0.5.2

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bdraco bdraco changed the title Bump bluetooth-auto-recovery to 0.5.0 Bump bluetooth-auto-recovery to 0.5.1 Nov 27, 2022
@bdraco bdraco marked this pull request as ready for review November 27, 2022 04:19
@bdraco bdraco closed this Nov 27, 2022
@bdraco bdraco reopened this Nov 27, 2022
@bdraco bdraco changed the title Bump bluetooth-auto-recovery to 0.5.1 Bump bluetooth-auto-recovery to 0.5.2 Nov 27, 2022
@Jc2k
Copy link
Member

Jc2k commented Nov 27, 2022

Are there any permissions we need to think about for this? Do you need to be root to do the ioctl? Or just own the file paths?

@bdraco
Copy link
Member Author

bdraco commented Nov 27, 2022

Are there any permissions we need to think about for this? Do you need to be root to do the ioctl? Or just own the file paths?

There are any number of potential failure cases so I used the same strategy I did for the power off/on rollout by adding exception catches and debug logging for already known failure paths and a broad exception catch and error logging for ones we don't know about yet.

As we discover what doesn't work for some users we can trap more exceptions and downgrade to debug if needed but I'm hoping not to do that because this is the last resort to get the adapter working and once we get here if we can't reset it's a cold boot to get things working again

@balloob balloob merged commit 6662dbf into home-assistant:dev Nov 27, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Nov 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants