Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace NINA corona filter with regex #83181

Merged
merged 3 commits into from Jun 28, 2023

Conversation

DeerMaximum
Copy link
Contributor

@DeerMaximum DeerMaximum commented Dec 3, 2022

Breaking change

Proposed change

This PR replaces the corona filter with the possibility to define your own regex to filter the warnings.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@github-actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label May 27, 2023
@DeerMaximum
Copy link
Contributor Author

Waiting for review

@github-actions github-actions bot removed the stale label May 27, 2023
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label May 29, 2023
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @DeerMaximum 👍

@emontnemery emontnemery merged commit 0bfb81e into home-assistant:dev Jun 28, 2023
6 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 29, 2023
@DeerMaximum DeerMaximum deleted the nina_ignore_string branch August 12, 2023 11:00
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

NINA Flood warnings NINA - wrong status after a warning
3 participants