Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bouncie integration #83247

Closed
wants to merge 48 commits into from
Closed

Add bouncie integration #83247

wants to merge 48 commits into from

Conversation

mandarons
Copy link
Contributor

@mandarons mandarons commented Dec 4, 2022

Proposed change

This is a new integration for Bouncie - a OBD2 based vehicle tracker. You can find more information at bouncie.com. This PR includes minimal implementation to interact with Boucie API.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@MartinHjelmare MartinHjelmare changed the title bouncie integration - bare minimum features Add bouncie integration Dec 4, 2022
@Quentame Quentame added this to Needs review in Dev via automation Dec 6, 2022
@Quentame Quentame added this to Incoming in New Integrations via automation Dec 6, 2022
Copy link
Member

@Quentame Quentame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Haven't looked at tests yet

CODEOWNERS Show resolved Hide resolved
homeassistant/components/bouncie/translations/en.json Outdated Show resolved Hide resolved
homeassistant/components/bouncie/strings.json Outdated Show resolved Hide resolved
homeassistant/components/bouncie/manifest.json Outdated Show resolved Hide resolved
homeassistant/components/bouncie/manifest.json Outdated Show resolved Hide resolved
homeassistant/components/bouncie/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/bouncie/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/bouncie/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/bouncie/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/bouncie/__init__.py Outdated Show resolved Hide resolved
Dev automation moved this from Needs review to Review in progress Dec 6, 2022
New Integrations automation moved this from Incoming to Awaiting Requested Changes Dec 6, 2022
mandarons and others added 7 commits December 6, 2022 11:28
Co-authored-by: Quentame <polletquentin74@me.com>
Co-authored-by: Quentame <polletquentin74@me.com>
Co-authored-by: Quentame <polletquentin74@me.com>
Co-authored-by: Quentame <polletquentin74@me.com>
Co-authored-by: Quentame <polletquentin74@me.com>
Co-authored-by: Quentame <polletquentin74@me.com>
Co-authored-by: Quentame <polletquentin74@me.com>
homeassistant/components/bouncie/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/bouncie/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/bouncie/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/bouncie/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/bouncie/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/bouncie/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/bouncie/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/bouncie/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/bouncie/sensor.py Outdated Show resolved Hide resolved
@Quentame
Copy link
Member

Quentame commented Dec 8, 2022

pip check fail seems unrelated to your code, try to update with merge or rebase.

@mandarons
Copy link
Contributor Author

pip check fail seems unrelated to your code, try to update with merge or rebase.

Done.

@mandarons
Copy link
Contributor Author

Closed all the review comments.

@mandarons
Copy link
Contributor Author

I will need to put this request on hold. I am working with Bouncie team to complete the integration with all the features that the API provides. Once completed, I will reopen this PR and submit the changes.

Closing it temporarily to save HA folks' time and effort.

@mandarons mandarons closed this Jan 17, 2023
Dev automation moved this from Review in progress to Cancelled Jan 17, 2023
New Integrations automation moved this from Awaiting Requested Changes to Cancelled Jan 17, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Cancelled
New Integrations
  
Cancelled
Development

Successfully merging this pull request may close these issues.

None yet

4 participants