Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump pip_check conflicts +1 #83536

Merged
merged 2 commits into from Dec 8, 2022
Merged

Bump pip_check conflicts +1 #83536

merged 2 commits into from Dec 8, 2022

Conversation

frenck
Copy link
Member

@frenck frenck commented Dec 8, 2022

Proposed change

Bumps the pip_check conflicts +1, due to a new conflict in a subdepdency of bsblan.
This bump in our pip_check will ensure the CI goes green again.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added cla-signed small-pr PRs with less than 30 lines. labels Dec 8, 2022
script/pip_check Outdated Show resolved Hide resolved
Co-authored-by: Philip Allgaier <mail@spacegaier.de>
@emontnemery emontnemery merged commit 5e81f85 into dev Dec 8, 2022
@emontnemery emontnemery deleted the frenck-2022-2198 branch December 8, 2022 11:44
@frenck frenck mentioned this pull request Dec 8, 2022
@balloob balloob added this to the 2022.12.1 milestone Dec 9, 2022
balloob pushed a commit that referenced this pull request Dec 9, 2022
* Bump pip_check conflicts +1

* Update script/pip_check

Co-authored-by: Philip Allgaier <mail@spacegaier.de>

Co-authored-by: Philip Allgaier <mail@spacegaier.de>
@github-actions github-actions bot locked and limited conversation to collaborators Dec 10, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cherry-picked cla-signed small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants