Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing preset for Overkiz atlantic electrical heater #84080

Merged

Conversation

nyroDev
Copy link
Contributor

@nyroDev nyroDev commented Dec 15, 2022

Proposed change

This add 2 preset for Overkiz atlantic electrical heater, requested in #83855

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @iMicknl, @vlebourl, @tetienne, mind taking a look at this pull request as it has been labeled with an integration (overkiz) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of overkiz can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign overkiz Removes the current integration label and assignees on the issue, add the integration domain after the command.

@nyroDev nyroDev changed the title Readd missing preset for Overkiz atlantic electrical heater Add missing preset for Overkiz atlantic electrical heater Dec 15, 2022
Copy link

@kevin-brown kevin-brown left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Quentame Quentame added this to Needs review in Dev via automation Dec 20, 2022
Copy link
Member

@Quentame Quentame left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Issue created in 2022.3 in #67045, but as the small code change won't interfere, let's fix 2022.12.x !

Dev automation moved this from Needs review to Reviewer approved Dec 20, 2022
@Quentame Quentame added this to the 2022.12.8 milestone Dec 20, 2022
@Quentame Quentame merged commit 2c238ba into home-assistant:dev Dec 20, 2022
Dev automation moved this from Reviewer approved to Done Dec 20, 2022
@github-actions github-actions bot locked and limited conversation to collaborators Dec 21, 2022
@nyroDev nyroDev deleted the overkiz/readd_preset_atlantic_heater branch December 21, 2022 13:42
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
Dev
  
Done
Development

Successfully merging this pull request may close these issues.

Don't have all the parameters on Cozytouch heaters (Overkiz component)
5 participants