Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump PySwitchbot to 0.29.1 #84119

Merged
merged 21 commits into from
Dec 19, 2022
Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Dec 17, 2022

Proposed change

changelog: Danielhiversen/pySwitchbot@0.23.2...0.29.1

fixes #82795 which improves handling of passive only data (although this is not officially supported at this time) and closes #78562

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @Danielhiversen, @RenierM26, @murtas, @Eloston, mind taking a look at this pull request as it has been labeled with an integration (switchbot) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of switchbot can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign switchbot Removes the current integration label and assignees on the issue, add the integration domain after the command.

@bdraco bdraco marked this pull request as draft December 17, 2022 02:20
@bdraco bdraco changed the title Speed up switchbot contact sensor with pySwitchbot 0.24.0 Bump PySwitchbot to 0.25.0 Dec 17, 2022
@bdraco bdraco marked this pull request as ready for review December 17, 2022 02:36
@bdraco bdraco marked this pull request as draft December 17, 2022 03:10
@bdraco bdraco changed the title Bump PySwitchbot to 0.25.0 Bump PySwitchbot to 0.26.0 Dec 17, 2022
@bdraco bdraco changed the title Bump PySwitchbot to 0.26.0 Bump PySwitchbot to 0.26.1 Dec 17, 2022
@bdraco bdraco changed the title Bump PySwitchbot to 0.26.1 Bump PySwitchbot to 0.26.2 Dec 17, 2022
@bdraco bdraco changed the title Bump PySwitchbot to 0.26.2 Bump PySwitchbot to 0.26.3 Dec 17, 2022
@bdraco bdraco marked this pull request as ready for review December 17, 2022 05:34
@bdraco bdraco changed the title Bump PySwitchbot to 0.26.3 Bump PySwitchbot to 0.27.0 Dec 17, 2022
@bdraco bdraco changed the title Bump PySwitchbot to 0.27.0 Bump PySwitchbot to 0.27.1 Dec 17, 2022
@bdraco bdraco closed this Dec 17, 2022
@bdraco bdraco reopened this Dec 17, 2022
@bdraco bdraco changed the title Bump PySwitchbot to 0.27.1 Bump PySwitchbot to 0.28.0 Dec 18, 2022
@bdraco bdraco changed the title Bump PySwitchbot to 0.28.0 Bump PySwitchbot to 0.29.0 Dec 18, 2022
@bdraco bdraco changed the title Bump PySwitchbot to 0.29.0 Bump PySwitchbot to 0.29.1 Dec 19, 2022
Copy link
Contributor

@bachya bachya left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏻

@bdraco
Copy link
Member Author

bdraco commented Dec 19, 2022

wemo test failure is unrelated
FAILED tests/components/wemo/test_binary_sensor.py::TestMaker::test_async_update_locked_multiple_callbacks - AssertionError

@bdraco bdraco merged commit 884fbdd into home-assistant:dev Dec 19, 2022
@bdraco bdraco deleted the switchbot_contact_speed_up branch December 19, 2022 00:54
@bdraco
Copy link
Member Author

bdraco commented Dec 19, 2022

thanks

@github-actions github-actions bot locked and limited conversation to collaborators Dec 20, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
3 participants