Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Restore speed when turning a Tasmota fan back on #84337

Merged
merged 1 commit into from Dec 22, 2022
Merged

Restore speed when turning a Tasmota fan back on #84337

merged 1 commit into from Dec 22, 2022

Conversation

emontnemery
Copy link
Contributor

Breaking change

Proposed change

Restore speed when turning a Tasmota fan back on

This is an alternative to #78718 which changes the default fan speed

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@emontnemery
Copy link
Contributor Author

@omaramin-2000 FYI, it would be great if you could give it a try

@emontnemery emontnemery mentioned this pull request Dec 21, 2022
Closed
23 tasks
jbouwh
jbouwh approved these changes Dec 21, 2022
View reviewed changes
Copy link
Contributor

@jbouwh jbouwh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice,
Thnx @emontnemery !

homeassistant/components/tasmota/fan.py Show resolved Hide resolved
@emontnemery emontnemery merged commit 41341c7 into dev Dec 22, 2022
@emontnemery emontnemery deleted the tasmota_fan_restore_speed branch December 22, 2022 08:31
@omaramin-2000
Copy link

Also, set the default speed to low if there wasn't a recently saved speed.

@github-actions github-actions bot locked and limited conversation to collaborators Dec 23, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jbouwh jbouwh jbouwh approved these changes

Assignees
No one assigned
Labels
by-code-owner cla-signed has-tests integration: tasmota new-feature Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@emontnemery @omaramin-2000 @jbouwh