Fix Fully Kiosk service call config entry handling #85275
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
bugfix
cla-signed
integration: fully_kiosk
small-pr
balloob
reviewed
Jan 6, 2023
| @@ -47,10 +47,19 @@ async def execute_service( | |||
| for target in call.data[ATTR_DEVICE_ID]: | |||
| device = registry.async_get(target) | |||
| if device: | |||
There was a problem hiding this comment.
For a future PR, this should probably raise if a user has pointed it at a non-existing device.
It can also be re-written to a guard clause to save on indentation
if device is None:
raise HomeAssistantError("Non-existing device")
balloob
reviewed
Jan 6, 2023
| coordinator = hass.data[DOMAIN][key] | ||
| # fully_method(coordinator.fully, *args, **kwargs) would make | ||
| # test_services.py fail. | ||
| await getattr(coordinator.fully, fully_method.__name__)( |
There was a problem hiding this comment.
Also for a future PR, but why pass in a method just to fetch it's name?
balloob
approved these changes
Jan 6, 2023
balloob
pushed a commit
that referenced
this pull request
Jan 6, 2023
* Make sure we're getting the fully_kiosk config entry * Make sure we're getting the fully_kiosk config entry
Merged
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
It's possible for a fully_kiosk device entry to have multiple config_entries listed (especially if using device tracking integrations like unifi or netgear). The existing service code assumed there would only be one config entry listed for the device. This fixes that to iterate through the config_entries for the device until we find the
fully_kioskconfig entry.Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: