Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add a calendar entity to ReCollect Waste #85347

Merged
merged 3 commits into from Jan 9, 2023
Merged

Add a calendar entity to ReCollect Waste #85347

merged 3 commits into from Jan 9, 2023

Conversation

bachya
Copy link
Contributor

@bachya bachya commented Jan 6, 2023 •
edited

Proposed change

SSIA. Note that the PR also touches the sensor platform—now that the coordinator is returning all known pickup events, we needed to adjust how the sensor grabs its information.

CleanShot 2023-01-06 at 15 51 59

CleanShot 2023-01-06 at 15 52 55

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@bachya bachya self-assigned this Jan 6, 2023
@bachya bachya mentioned this pull request Jan 6, 2023
Merged
8 tasks
@bachya bachya changed the title Recollect calendar entity Add a calendar entity to ReCollect Waste Jan 6, 2023
allenporter
allenporter reviewed Jan 9, 2023
View reviewed changes
Copy link
Contributor

@allenporter allenporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great overall, just have one minor point on the end date.

homeassistant/components/recollect_waste/calendar.py Outdated Show resolved Hide resolved
@bachya
Copy link
Contributor Author

bachya commented Jan 9, 2023

Thanks, @allenporter!

@bachya bachya merged commit e35b218 into home-assistant:dev Jan 9, 2023
@bachya bachya deleted the recollect-calendar-entity branch January 9, 2023 16:50
@github-actions github-actions bot locked and limited conversation to collaborators Jan 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare left review comments

@allenporter allenporter allenporter approved these changes

Assignees

@bachya bachya

Labels
by-code-owner cla-signed integration: recollect_waste new-feature new-platform Quality Scale: No score
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@bachya @MartinHjelmare @allenporter