New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Ezviz update entity #85377
Add Ezviz update entity #85377
Conversation
Hey there @BaQs, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
ffb5882
to
933354b
Compare
933354b
to
d99cd43
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Very tiny tweak left, otherwise it looks good 👍
../Frenck
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
9ec0a65
to
dd74392
Compare
homeassistant/components/ezviz/update.py:49: error: "UpdateEntity" expects no type arguments, but 1 given [type-arg]
Remove redundant coordinator definition.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, @RenierM26 👍
../Frenck
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
Breaking change
Binary sensor "Upgrade_Available" is replaced with new Update Entity.
Proposed change
Add Update entity with Progress and release notes.
Bump API for extra firmware release info required by Entity.
Full Changelog: BaQs/pyEzviz@0.2.0.9...0.2.0.12
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: