Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Ezviz update entity #85377

Merged
merged 10 commits into from May 23, 2023
Merged

Conversation

RenierM26
Copy link
Contributor

@RenierM26 RenierM26 commented Jan 7, 2023

Breaking change

Binary sensor "Upgrade_Available" is replaced with new Update Entity.

Proposed change

Add Update entity with Progress and release notes.

Bump API for extra firmware release info required by Entity.
Full Changelog: BaQs/pyEzviz@0.2.0.9...0.2.0.12

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Jan 7, 2023

Hey there @BaQs, mind taking a look at this pull request as it has been labeled with an integration (ezviz) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of ezviz can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign ezviz Removes the current integration label and assignees on the issue, add the integration domain after the command.

homeassistant/components/ezviz/update.py Outdated Show resolved Hide resolved
homeassistant/components/ezviz/update.py Outdated Show resolved Hide resolved
homeassistant/components/ezviz/update.py Outdated Show resolved Hide resolved
homeassistant/components/ezviz/update.py Outdated Show resolved Hide resolved
homeassistant/components/ezviz/update.py Outdated Show resolved Hide resolved
homeassistant/components/ezviz/update.py Outdated Show resolved Hide resolved
homeassistant/components/ezviz/update.py Outdated Show resolved Hide resolved
@MartinHjelmare MartinHjelmare changed the title Ezviz : Add update entity Add Ezviz update entity Jan 8, 2023
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Very tiny tweak left, otherwise it looks good 👍

../Frenck

homeassistant/components/ezviz/update.py Show resolved Hide resolved
homeassistant/components/ezviz/update.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft May 21, 2023 18:59
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@RenierM26 RenierM26 marked this pull request as ready for review May 22, 2023 05:31
@home-assistant home-assistant bot requested a review from frenck May 22, 2023 05:32
homeassistant/components/ezviz/update.py:49: error: "UpdateEntity" expects no type arguments, but 1 given  [type-arg]
Remove redundant coordinator definition.
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @RenierM26 👍

../Frenck

@frenck frenck merged commit 497fa19 into home-assistant:dev May 23, 2023
52 checks passed
teharris1 pushed a commit to teharris1/home-assistant that referenced this pull request May 23, 2023
Co-authored-by: Franck Nijhof <frenck@frenck.nl>
@RenierM26 RenierM26 deleted the ezviz_add_update_entity branch May 23, 2023 16:40
@github-actions github-actions bot locked and limited conversation to collaborators May 24, 2023
@frenck frenck added the noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) label May 30, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants