Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Google Assistant SDK: TTS for response playback #85416

Closed

Conversation

tronikos
Copy link
Contributor

@tronikos tronikos commented Jan 8, 2023

Proposed change

Support TTS in Google Assistant SDK to be able to playback Google Assistant's audio response.

Users will need to add:

tts:
  - platform: google_assistant_sdk

and then they can call:

service: tts.google_assistant_sdk_say
data:
  message: tell me a joke
  entity_id: media_player.living_room_speaker
  cache: false

Underlyging library changes:
tronikos/gassist_text@0.0.7...0.0.8

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Contributor

@allenporter allenporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I haven't reviewed a tts service before but it looks pretty straight forward. Great! 👍🏼

@tronikos tronikos force-pushed the google_assistant_sdk_log branch 2 times, most recently from b9661c7 to fd5aabf Compare January 10, 2023 18:14
@tronikos tronikos marked this pull request as draft January 14, 2023 08:22
@tronikos
Copy link
Contributor Author

A better alternative to this is #85989 since this isn't really TTS. It's more like text to answer’s speech.

@tronikos tronikos closed this Jan 24, 2023
@tronikos tronikos deleted the google_assistant_sdk_log branch January 24, 2023 16:26
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants