Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revert "Bump steamodd to 4.23" #85651

Merged
merged 1 commit into from Jan 11, 2023
Merged

Conversation

jbouwh
Copy link
Contributor

@jbouwh jbouwh commented Jan 10, 2023

Reverts #85071

The change causes dependency issues.

Closes #85650

@home-assistant
Copy link

Hey there @tkdrob, mind taking a look at this pull request as it has been labeled with an integration (steam_online) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of steam_online can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign steam_online Removes the current integration label and assignees on the issue, add the integration domain after the command.

@tkdrob
Copy link
Contributor

tkdrob commented Jan 10, 2023

Did you run script/setup recently and which python version do you have? It should be 3.10.

@jbouwh
Copy link
Contributor Author

jbouwh commented Jan 10, 2023

Did you run script/setup recently and which python version do you have? It should be 3.10.

I regenerated a fresh dev container. These stil run python 3.9.14.

Running script/setup does not affect the python version in the dev container.

@tkdrob
Copy link
Contributor

tkdrob commented Jan 10, 2023

This does not explain why then the CI does not fail? Try 3.10

@jbouwh
Copy link
Contributor Author

jbouwh commented Jan 10, 2023

This does not explain why then the CI does not fail? Try 3.10

Isn't the Python version is linked to the devcontainer.dev, I cannot just change that?

@tkdrob
Copy link
Contributor

tkdrob commented Jan 10, 2023

What version of setuptools are you running in the container?

@jbouwh
Copy link
Contributor Author

jbouwh commented Jan 10, 2023

the

What version of setuptools are you running in the container?

vscode ➜ /workspaces/core (dev) $ pip show setuptools
Name: setuptools
Version: 58.1.0
Summary: Easily download, build, install, upgrade, and uninstall Python packages
Home-page: https://github.com/pypa/setuptools
Author: Python Packaging Authority
Author-email: distutils-sig@python.org
License: UNKNOWN
Location: /usr/local/lib/python3.9/site-packages
Requires: 
Required-by: acme, APScheduler, colorzero, fitbit, influxdb-client, josepy, nodeenv, pulsectl, pure-pcapy3, pycocotools, pycountry, tellsticknet, yamllint, zope.interface

@tkdrob
Copy link
Contributor

tkdrob commented Jan 10, 2023

pypa/setuptools@974dbb0

OptionError looks to have been added after 58.1.0. I'm on 65.5.0 and am not getting this error.

@jbouwh
Copy link
Contributor Author

jbouwh commented Jan 10, 2023

pypa/setuptools@974dbb0

OptionError looks to have been added after 58.1.0. I'm on 65.5.0 and am not getting this error.

Unfortually the newer version of steamodd with the older version of setuptools seems to break the requirements setup in dev containers.

@jbouwh jbouwh added the bugfix label Jan 10, 2023
@tkdrob
Copy link
Contributor

tkdrob commented Jan 11, 2023

I use a mac, not dev containers but I believe in project.toml you can set a different requirement for setuptools. Try that.

@jbouwh
Copy link
Contributor Author

jbouwh commented Jan 11, 2023

pyproject.toml (is allowing 3.9 and 3.10
requires = ["setuptools~=62.3", "wheel~=0.37.1"]

We cannot just change this. Python 3.9.14 is deprecated but support is still going on, you cannot just break that.

Copy link
Member

@MartinHjelmare MartinHjelmare left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's go ahead with the revert. A single integration should not stop our development flow. Then we have time to figure out the best solution. 👍

Thanks!

@MartinHjelmare MartinHjelmare merged commit 1a4cac9 into dev Jan 11, 2023
@MartinHjelmare MartinHjelmare deleted the revert-85071-steamodd_4.23 branch January 11, 2023 12:13
@tkdrob
Copy link
Contributor

tkdrob commented Jan 11, 2023

TBH, I might get this package replaced. It's doing some stupid stuff besides this.

@github-actions github-actions bot locked and limited conversation to collaborators Jan 12, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Required package steamodd==4.23 cannot be installed
3 participants