Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean up legacy import from HomeWizard #85960

Merged
merged 1 commit into from Jan 15, 2023
Merged

Clean up legacy import from HomeWizard #85960

merged 1 commit into from Jan 15, 2023

Conversation

frenck
Copy link
Member

@frenck frenck commented Jan 15, 2023

Proposed change

Cleans up the legacy import from the custom integration from HomeWizard.
This import has been here for 11 months now (or regular deprecation/migration period is two release cycles); time to clean it up.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @DCSBL, mind taking a look at this pull request as it has been labeled with an integration (homewizard) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of homewizard can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign homewizard Removes the current integration label and assignees on the issue, add the integration domain after the command.

@thecode thecode merged commit 91ac640 into dev Jan 15, 2023
@thecode thecode deleted the frenck-2023-0097 branch January 15, 2023 18:14
@DCSBL
Copy link
Contributor

DCSBL commented Jan 15, 2023

We also should remove this ;) →

async def async_step_import(self, import_config: dict[str, Any]) -> FlowResult:
"""Handle a flow initiated by older `homewizard_energy` component."""
_LOGGER.debug("config_flow async_step_import")
persistent_notification.async_create(
self.hass,
title="HomeWizard Energy",
message=(
"The custom integration of HomeWizard Energy has been migrated to core."
" You can safely remove the custom integration from the"
" custom_integrations folder."
),
notification_id=f"homewizard_energy_to_{DOMAIN}",
)
return await self.async_step_user({CONF_IP_ADDRESS: import_config["host"]})
.

@frenck
Copy link
Member Author

frenck commented Jan 15, 2023

Well spotted! Sorry about that, will do 👍

janiversen pushed a commit to janiversen/core that referenced this pull request Jan 16, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 16, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants