Add Dremel 3D Printer integration #85969
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 tasks
jbouwh
reviewed
Jan 22, 2023
…mel_3d_printer
teharris1
reviewed
May 12, 2023
| api = await self.hass.async_add_executor_job(Dremel3DPrinter, host) | ||
| except (ConnectTimeout, HTTPError, JSONDecodeError): | ||
| errors = {"base": "cannot_connect"} | ||
| except Exception: # pylint: disable=broad-except |
There was a problem hiding this comment.
Do you really need this broad exception? Is there no way to box this into known exception types?
There was a problem hiding this comment.
All the known exceptions are classified as cannot_connect. Is the broad except not standard for config_flow anymore?
There was a problem hiding this comment.
It’s alright, it gives the best user experience because the flow doesn’t crash, just says something bad happened. However, you should log the exception _LOGGER.exception(…) to make sure we can see where the unknown error happened.
balloob
reviewed
May 31, 2023
balloob
reviewed
May 31, 2023
balloob
reviewed
May 31, 2023
balloob
reviewed
May 31, 2023
balloob
requested changes
May 31, 2023
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
22 tasks
balloob
reviewed
May 31, 2023
balloob
approved these changes
May 31, 2023
11 tasks
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Add the integration for the Dremel 3D Printer, models 3D20, 3D40 and 3D45. Dremel manufactures a high-tech 3D printer that does not integrate with OctoPrint. It has its own API built-in and, for the latest model (3D45), its own camera. This integration adds a config flow to add a Dremel 3D Printer based on its Host IP.
#72235 appears to have been abandoned. This is my own submission with much needed changes to keep up with the new standards. Only the sensor platform is exposed to start with to make review easier.
There is a custom integration in HACS so we already have it in the brands repo.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: