Add Anova integration #86254

Lash-L · 2023-01-19T22:06:19Z

Proposed change

Adding read only entities for Anova Sous Vides with Wifi support. Uses anova-wifi

Type of change

Dependency upgrade
Bugfix (non-breaking change which fixes an issue)
New integration (thank you!)
New feature (which adds functionality to an existing integration)
Deprecation (breaking change to happen in the future)
Breaking change (fix/feature causing existing functionality to break)
Code quality improvements to existing code or addition of tests

Additional information

This PR fixes or closes issue: fixes #
This PR is related to issue:
Link to documentation pull request: Setup of anova docs home-assistant.io#25851

Checklist

The code change is tested and works locally.
Local tests pass. Your PR cannot be merged unless tests pass
There is no commented out code in this PR.
I have followed the development checklist
The code has been formatted using Black (black --fast homeassistant tests)
Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

The manifest file has all fields filled out correctly.
Updated and included derived files by running: python3 -m script.hassfest.
New or updated dependencies have been added to requirements_all.txt.
Updated by running python3 -m script.gen_requirements_all.
For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

I have reviewed two other open pull requests in this repository.

dshokouhi · 2023-01-20T03:54:01Z

I noticed that the docs mentioned YAML configuration. I don't think that will be accepted here per ADR 0010 integrations that communicate with a device/service should be config flow only.

Lash-L · 2023-01-20T14:07:06Z

I noticed that the docs mentioned YAML configuration. I don't think that will be accepted here per ADR 0010 integrations that communicate with a device/service should be config flow only.

Thanks for the heads up! I have resolved that now

home-assistant · 2023-01-22T22:27:21Z

Hi Lash-L

It seems you haven't yet signed a CLA. Please do so here.

Once you do that we will be able to review and accept this pull request.

Thanks!

homeassistant/components/anova_sous_vide/manifest.json

Vaskivskyi

Hello. I have a couple of comments which might help improve the code a bit as well as the component itself

homeassistant/components/anova_sous_vide/config_flow.py

homeassistant/components/anova_sous_vide/sensor.py

into anova_precission_cooker

homeassistant/components/anova/__init__.py

homeassistant/components/anova/config_flow.py

homeassistant/components/anova/__init__.py

into anova_precission_cooker

Lash-L · 2023-04-22T21:40:11Z

Not sure why that Mariadb one keeps failing- I assume it's just the ci pipeline being weird?

homeassistant/components/anova/strings.json

bdraco · 2023-04-22T22:21:32Z

Not sure why that Mariadb one keeps failing- I assume it's just the ci pipeline being weird?

I think I recently fixed that test. It might have just needed dev merged in

Co-authored-by: J. Nick Koston <nick@koston.org>

Lash-L · 2023-04-22T23:12:28Z

Thanks bdraco! I appreciate all your help!

* init setup of Anova Sous Vide * bump anova-wifi to 0.2.4 * Removed yaml support * Bump to anova-wifi 0.2.5 * Added support for adding sous vide while offline * Added basic test for sensor * added better tests for sensors and init * expanded code coverage * Decreased timedelta to lowest functioning value. * Updating my username * migrate to async_forward_entry_setups * applying pr recommended changes * bump anova-wifi to 0.2.7 * Improvements to hopefully get this review ready * formatting changes * clean ups for pr review * remove unneeded unique id check. * bump ao anova_wifi 0.3.0 * rename device_id to device_unique_id * renamed to 'anova' * added unique_id to MockConfigEntry * removed leftover anova sous vides * added device id to strings * added error for incorrect device id * add has_entity_name * added attr name for tests * added authentication functionality * bump to 0.4.3 * split entity into its own class/object * pulling firmware version out of async_setup Co-authored-by: J. Nick Koston <nick@koston.org> * addressed pr changes * fixed pytest * added anova data model * removed unneeded time change * add logging in package * rework step_user * Update homeassistant/components/anova/sensor.py Co-authored-by: J. Nick Koston <nick@koston.org> * Removed lower from attr unique id Co-authored-by: J. Nick Koston <nick@koston.org> * Removed unneeded member variables in sensor Co-authored-by: J. Nick Koston <nick@koston.org> * removed repeated subclass attr Co-authored-by: J. Nick Koston <nick@koston.org> * simplify update_failed test * created descriptionentity * bump to 0.6.1 limit ws connect * add translation for sensor entities * version bump - support pro model * add anova to strict typing * fixed sensor not getting datas type * Apply suggestions from code review Co-authored-by: J. Nick Koston <nick@koston.org> * Check for new devices in init * style changes * return false instead of config entry not ready * move serialize_device_list to utils * move repeating device check into api * moved unneeded code out of try except * fixed tests to get 100% cov * Update homeassistant/components/anova/strings.json Co-authored-by: J. Nick Koston <nick@koston.org> --------- Co-authored-by: J. Nick Koston <nick@koston.org>

init setup of Anova Sous Vide

f43253e

home-assistant bot added cla-signed has-tests new-integration integration: anova_sous_vide labels Jan 19, 2023

This was referenced Jan 19, 2023

Anova sous vide documenation home-assistant/home-assistant.io#25849

Closed

added branding for anova home-assistant/brands#4050

Merged

Setup of anova docs home-assistant/home-assistant.io#25851

Merged

bump anova-wifi to 0.2.4

3429b05

Removed yaml support

6611972

Lash-L added 5 commits January 20, 2023 15:13

Bump to anova-wifi 0.2.5

2faa442

Added support for adding sous vide while offline

b446cbd

Added basic test for sensor

64d593c

added better tests for sensors and init

03ff1b6

expanded code coverage

4e645e2

Lash-L changed the title ~~New Anova Sous Vide integrartion~~ New Anova Sous Vide integration Jan 21, 2023

Lash-L added 4 commits January 21, 2023 09:06

Merge branch 'dev' into anova_precission_cooker

9cc286e

Merge branch 'dev' into anova_precission_cooker

9e74755

Decreased timedelta to lowest functioning value.

7019bc3

Updating my username

5b72aa0

home-assistant bot added the cla-needed label Jan 22, 2023

home-assistant bot added cla-recheck and removed cla-recheck cla-needed labels Jan 22, 2023

migrate to async_forward_entry_setups

b8155d6

Vaskivskyi reviewed Jan 27, 2023

View reviewed changes

homeassistant/components/anova_sous_vide/manifest.json Outdated Show resolved Hide resolved

Vaskivskyi reviewed Jan 27, 2023

View reviewed changes

homeassistant/components/anova_sous_vide/config_flow.py Outdated Show resolved Hide resolved

homeassistant/components/anova_sous_vide/sensor.py Outdated Show resolved Hide resolved

homeassistant/components/anova_sous_vide/sensor.py Outdated Show resolved Hide resolved

Lash-L added 3 commits April 20, 2023 23:52

Check for new devices in init

4616d9a

Merge branch 'anova_precission_cooker' of https://github.com/Lash-L/core

e039391

into anova_precission_cooker

style changes

b796766

bdraco reviewed Apr 20, 2023

View reviewed changes

homeassistant/components/anova/__init__.py Outdated Show resolved Hide resolved

bdraco reviewed Apr 20, 2023

View reviewed changes

homeassistant/components/anova/__init__.py Outdated Show resolved Hide resolved

bdraco reviewed Apr 21, 2023

View reviewed changes

homeassistant/components/anova/config_flow.py Outdated Show resolved Hide resolved

Lash-L added 3 commits April 21, 2023 01:32

return false instead of config entry not ready

1d4189b

move serialize_device_list to utils

ad803d1

Merge branch 'dev' into anova_precission_cooker

1999ca8

bdraco reviewed Apr 21, 2023

View reviewed changes

homeassistant/components/anova/__init__.py Outdated Show resolved Hide resolved

Lash-L added 2 commits April 21, 2023 13:22

move repeating device check into api

95d0389

Merge branch 'dev' into anova_precission_cooker

34974a0

bdraco reviewed Apr 21, 2023

View reviewed changes

homeassistant/components/anova/__init__.py Outdated Show resolved Hide resolved

Lash-L and others added 5 commits April 21, 2023 15:01

moved unneeded code out of try except

0c0ca93

Merge branch 'anova_precission_cooker' of https://github.com/Lash-L/core

f47c46c

into anova_precission_cooker

fixed tests to get 100% cov

9a8cecb

Merge branch 'dev' into anova_precission_cooker

1256e6c

Merge branch 'dev' into anova_precission_cooker

634cfbc

bdraco approved these changes Apr 22, 2023

View reviewed changes

Merge branch 'dev' into anova_precission_cooker

287c2b2

bdraco reviewed Apr 22, 2023

View reviewed changes

homeassistant/components/anova/strings.json Outdated Show resolved Hide resolved

Update homeassistant/components/anova/strings.json

b6bab99

Co-authored-by: J. Nick Koston <nick@koston.org>

bdraco approved these changes Apr 22, 2023

View reviewed changes

bdraco added the smash Indicator this PR is close to finish for merging or closing label Apr 22, 2023

bdraco merged commit 498e696 into home-assistant:dev Apr 22, 2023
51 checks passed

github-actions bot locked and limited conversation to collaborators Apr 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add Anova integration #86254

Add Anova integration #86254

Lash-L commented Jan 19, 2023 •

edited

dshokouhi commented Jan 20, 2023

Lash-L commented Jan 20, 2023

home-assistant bot commented Jan 22, 2023

Vaskivskyi left a comment

Lash-L commented Apr 22, 2023

bdraco commented Apr 22, 2023

Lash-L commented Apr 22, 2023

Add Anova integration #86254

Add Anova integration #86254

Conversation

Lash-L commented Jan 19, 2023 • edited

Proposed change

Type of change

Additional information

Checklist

dshokouhi commented Jan 20, 2023

Lash-L commented Jan 20, 2023

home-assistant bot commented Jan 22, 2023

Vaskivskyi left a comment

Choose a reason for hiding this comment

Lash-L commented Apr 22, 2023

bdraco commented Apr 22, 2023

Lash-L commented Apr 22, 2023

Lash-L commented Jan 19, 2023 •

edited