Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Simplify parsing of user input during config flow for generic #86256

Merged
merged 2 commits into from Jun 27, 2023

Conversation

davet2001
Copy link
Contributor

Proposed change

PR #75299 was started to deal with an issue that is now no longer causing problems, so the PR is no longer needed now.

Part of that change was to reduce the code relating to reading user input during config flow.

This PR just has the code reduction.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@github-actions
Copy link

There hasn't been any activity on this pull request recently. This pull request has been automatically marked as stale because of that and will be closed if no further activity occurs within 7 days.
Thank you for your contributions.

@github-actions github-actions bot added the stale label Apr 25, 2023
@davet2001
Copy link
Contributor Author

Still wanted

@github-actions github-actions bot removed the stale label Apr 26, 2023
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Apr 26, 2023
@home-assistant
Copy link

home-assistant bot commented May 5, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft May 5, 2023 12:26
@davet2001 davet2001 marked this pull request as ready for review June 4, 2023 10:42
Copy link
Member

@gjohansson-ST gjohansson-ST left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @davet2001 👍

../Frenck

@frenck frenck merged commit 7fa86d3 into home-assistant:dev Jun 27, 2023
6 checks passed
shbatm pushed a commit to shbatm/home-assistant-core that referenced this pull request Jun 27, 2023
…ssistant#86256)

Co-authored-by: Dave T <davet2001@users.noreply.github.com>
@github-actions github-actions bot locked and limited conversation to collaborators Jun 28, 2023
@davet2001 davet2001 deleted the generic_simplify_config2 branch October 11, 2023 20:37
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
by-code-owner cla-signed code-quality integration: generic Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants