Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update Ruff to 0.0.231, enable D401 #86520

Merged
merged 1 commit into from Jan 24, 2023
Merged

Update Ruff to 0.0.231, enable D401 #86520

merged 1 commit into from Jan 24, 2023

Conversation

akx
Copy link
Contributor

@akx akx commented Jan 24, 2023

Proposed change

This PR upgrades Ruff (see #86224) to version 0.0.231 and enables the D401 rule (thanks for fixing it, @scop)!

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Checklist

  • The code change is tested and works locally.

  • Local tests pass. Your PR cannot be merged unless tests pass

  • There is no commented out code in this PR.

  • I have followed the development checklist

  • The code has been formatted using Black (black --fast homeassistant tests)

  • Tests have been added to verify that the new code works.

  • New or updated dependencies have been added to requirements_all.txt.

  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
    To help with the load of incoming pull requests:

  • I have reviewed two other open pull requests in this repository.

@home-assistant home-assistant bot added cla-signed code-quality small-pr PRs with less than 30 lines. labels Jan 24, 2023
@akx akx marked this pull request as ready for review January 24, 2023 11:47
@akx akx requested a review from a team as a code owner January 24, 2023 11:47
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @akx 👍

../Frenck

@frenck frenck merged commit 65ad953 into home-assistant:dev Jan 24, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed code-quality small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants