Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate homematicip_cloud to use async_forward_entry_setups #86563

Merged

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Jan 24, 2023

Proposed change

Replaces deprecated async_setup_platforms with async_forward_entry_setups

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Replaces deprecated async_setup_platforms with async_forward_entry_setups
@bdraco
Copy link
Member Author

bdraco commented Jan 24, 2023

Its mocking hass as Mock in the test 😢

@bdraco
Copy link
Member Author

bdraco commented Jan 24, 2023

There are many tests here that are digging into the internals and patching hass. They should be fixed but its beyond the scope of this PR

@bdraco bdraco marked this pull request as ready for review January 24, 2023 19:56
@bdraco bdraco added the smash Indicator this PR is close to finish for merging or closing label Jan 24, 2023
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @bdraco 👍

@emontnemery emontnemery merged commit 3bfdba5 into home-assistant:dev Jan 25, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 26, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed code-quality integration: homematicip_cloud Quality Scale: silver small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants