Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase async_setup_platforms deprecation logging to warning #86582

Merged
merged 1 commit into from Jan 25, 2023
Merged

Increase async_setup_platforms deprecation logging to warning #86582

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 2 additions & 2 deletions homeassistant/config_entries.py
View file
Open in desktop
Expand Up @@ -1327,10 +1327,10 @@ def async_setup_platforms(
report(
(
"called async_setup_platforms instead of awaiting"
" async_forward_entry_setups; this will fail in version 2022.12"
" async_forward_entry_setups; this will fail in version 2023.3"
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That means only one release instead of the usual two.

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Its been deprecated since 2022.8.0. I was thinking adding another month was a courtesy.

This was deprecated in cd03c49fc27

It was properly labeled as a breaking change and got a blog post so I think its been more than enough time.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

#73806 lists quite a lot of integrations which need to do their homework. Is that list kept up to date, or is the list shorter now?
Oh, you've opened PRs @bdraco ❤️

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

All of them have been updated except for the ones that have open PRs that are not yet merged

),
# Raise this to warning once all core integrations have been migrated
level=logging.DEBUG,
level=logging.WARNING,
error_if_core=False,
)
for platform in platforms:
Expand Down