-
-
Notifications
You must be signed in to change notification settings - Fork 29k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix statistics graphs not loading with data_rate, electric_current, voltage, information, and unitless units #87202
Conversation
This was resulting in the stats graphs not loading on the frontend
Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
Could we add a test, similar to #87138 ? |
Still seeing an issue |
Its working now. Will try to find time to add a test later today |
Maybe the test shouldn't be in patch... |
Will add it if I get free cycles, if not it can always come later |
If not I can do a follow-up tomorrow. |
Makes sense. Let's do the test in a separate PR and get this fixed in 2023.2.x |
…oltage, information, and unitless units (#87202) * Add missing converts to recorder/statistics_during_period API This was resulting in the stats graphs not loading on the frontend * its in two places
Proposed change
Add missing converters to the
recorder/statistics_during_period
API schemaThis was resulting in the stats graphs not loading on the frontend
related issue #87137
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: