Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix disabled condition within an automation action #87213

Merged
merged 3 commits into from
Feb 2, 2023
Merged

Fix disabled condition within an automation action #87213

merged 3 commits into from
Feb 2, 2023

Conversation

karliemeads
Copy link
Contributor

@karliemeads karliemeads commented Feb 2, 2023

Proposed change

Conditions are checked seperately if they are not within the action section of an automation such as within if then or choose. This was not caught in #79718

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the [development checklist][dev-checklist]
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

@karliemeads karliemeads changed the title Fix disabled condition within an "If Then" action Fix disabled condition within an action Feb 2, 2023
@karliemeads karliemeads changed the title Fix disabled condition within an action Fix disabled condition within an automation action Feb 2, 2023
@frenck frenck added this to the 2023.2.1 milestone Feb 2, 2023
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @karliemeads 👍

Marked it for the patch release, as the existing breaking change already covers this case.

../Frenck

@frenck frenck merged commit e40a982 into home-assistant:dev Feb 2, 2023
@karliemeads karliemeads deleted the patch-2 branch February 2, 2023 21:35
balloob pushed a commit that referenced this pull request Feb 2, 2023
@balloob balloob mentioned this pull request Feb 2, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Feb 3, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Disabled conditions evaluated as false after Core 2023.2 update
3 participants