Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support local push updates for most ScreenLogic entities #87438

Merged
merged 13 commits into from
Feb 7, 2023
Merged

Support local push updates for most ScreenLogic entities #87438

merged 13 commits into from
Feb 7, 2023

Conversation

dieselrabbit
Copy link
Contributor

@dieselrabbit dieselrabbit commented Feb 5, 2023 •
edited by bdraco
Loading

Proposed change

Support local push updates for most entities.

dep changelog: dieselrabbit/screenlogicpy@v0.6.4...v0.7.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Feb 5, 2023

Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration (screenlogic) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of screenlogic can trigger bot actions by commenting:

  • @home-assistant close Closes the issue.
  • @home-assistant rename Awesome new title Change the title of the issue.
  • @home-assistant reopen Reopen the issue.
  • @home-assistant unassign screenlogic Removes the current integration label and assignees on the issue, add the integration domain after the command.

@dieselrabbit dieselrabbit mentioned this pull request Feb 5, 2023
Closed
19 tasks
bdraco
bdraco reviewed Feb 5, 2023
View reviewed changes
Copy link
Member

@bdraco bdraco left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good.

Some small suggestions on mobile to make this a bit more DRY and compact.

I'll give some better feedback when I'm back at my desk.

homeassistant/components/screenlogic/entity.py Outdated Show resolved Hide resolved
homeassistant/components/screenlogic/entity.py Outdated Show resolved Hide resolved
homeassistant/components/screenlogic/entity.py Outdated Show resolved Hide resolved
homeassistant/components/screenlogic/entity.py Outdated Show resolved Hide resolved
homeassistant/components/screenlogic/entity.py Outdated Show resolved Hide resolved
homeassistant/components/screenlogic/__init__.py Outdated Show resolved Hide resolved
homeassistant/components/screenlogic/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/screenlogic/sensor.py Outdated Show resolved Hide resolved
homeassistant/components/screenlogic/entity.py Outdated Show resolved Hide resolved
homeassistant/components/screenlogic/binary_sensor.py Outdated Show resolved Hide resolved
@dieselrabbit dieselrabbit mentioned this pull request Feb 6, 2023
Closed
@bdraco
Copy link
Member

bdraco commented Feb 6, 2023

Just tested this on production. It works really well 👍 Nice work

@bdraco bdraco added the noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) label Feb 6, 2023
bdraco
bdraco reviewed Feb 6, 2023
View reviewed changes
homeassistant/components/screenlogic/binary_sensor.py

entities.extend(
[
ScreenlogicConfigBinarySensor(coordinator, cfg_sensor)
for cfg_sensor in coordinator.data[SL_DATA.KEY_CONFIG]
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In a future PR : We could probably refactor this to use BinarySensorEntityDescription with a lambda to get the value

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

May need some guidance on that.
That said, in a future release of screenlogicpy I was thinking about moving those entities out of "config" and into "sensors" as I now know that data represents a live value, and not a configuration setting.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

TIL about EntityDescriptions. Interesting.

@dieselrabbit dieselrabbit marked this pull request as ready for review February 7, 2023 00:39
@bdraco bdraco self-requested a review February 7, 2023 00:59
bdraco
bdraco approved these changes Feb 7, 2023
View reviewed changes
Copy link
Member

@bdraco bdraco left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested on 2 production instances.

Thanks @dieselrabbit

@bdraco bdraco merged commit 687d326 into home-assistant:dev Feb 7, 2023
@dieselrabbit dieselrabbit deleted the sl-push branch February 7, 2023 02:41
@github-actions github-actions bot locked and limited conversation to collaborators Feb 8, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@bdraco bdraco bdraco approved these changes

Assignees

@bdraco bdraco

Labels
by-code-owner cla-signed dependency integration: screenlogic new-feature noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) Quality Scale: No score
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dieselrabbit @bdraco