Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore original aiohttp cancelation behavior #88046

Merged
merged 6 commits into from Feb 14, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Feb 14, 2023

Proposed change

aiohttp will now preserve the 3.8.1 handler cancellation on disconnect behavior which is now the unreleased 3.9.x version behavior of setting handler_cancellation to True (docs: aio-libs/aiohttp#7128)

This shim can be removed when 3.9.x is released and replaced with setting handler_cancellation to True

#88032 (comment)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant home-assistant bot added cla-signed core small-pr PRs with less than 30 lines. labels Feb 14, 2023
@bdraco bdraco marked this pull request as ready for review February 14, 2023 04:00
@bdraco bdraco requested a review from a team as a code owner February 14, 2023 04:00
@bdraco bdraco merged commit e41af89 into home-assistant:dev Feb 14, 2023
@bdraco bdraco deleted the aiohttp_old_behavior branch February 14, 2023 04:00
@github-actions github-actions bot locked and limited conversation to collaborators Feb 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla-signed core small-pr PRs with less than 30 lines.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants