-
-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Tweak typing of Entity.platform #88321
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
code-quality
core
small-pr
PRs with less than 30 lines.
labels
Feb 17, 2023
I'm missing the motivation for this PR in the PR description. |
19 tasks
emontnemery
force-pushed
the
entity_tweak_hass_platform
branch
from
March 31, 2023 13:43
065800b
to
dbaf0a6
Compare
emontnemery
changed the title
Tweak typing of Entity.hass and Entity.platform
Tweak typing of Entity.platform
Mar 31, 2023
Can you give an example where there was needed checks or asserts? What are you working on? It's nice to have some more context. |
emontnemery
force-pushed
the
entity_tweak_hass_platform
branch
from
June 9, 2023 07:17
dbaf0a6
to
d9e6121
Compare
MartinHjelmare
approved these changes
Jun 9, 2023
This was referenced Jun 9, 2023
MartinHjelmare
approved these changes
Jun 9, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
Tweak typing of
Entity.platform
in a similar manner as we typeEntity.hass
to avoid unnecessary None-checks or assertsBackground:
Both
Entity.hass
andEntity.platform
are assigned inEntity.add_to_platform_start
and unassigned inEntity.add_to_platform_abort
. This means that for basically the entire life cycle of anEntity
object, both itshass
andplatform
members have a valid value.Needs #90585
Type of change
Additional information
Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: