Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update nibe library to 2.0.0 #88769

Merged
merged 1 commit into from Feb 26, 2023
Merged

Update nibe library to 2.0.0 #88769

merged 1 commit into from Feb 26, 2023

Conversation

elupus
Copy link
Contributor

@elupus elupus commented Feb 25, 2023 •
edited

Proposed change

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

MartinHjelmare
MartinHjelmare approved these changes Feb 26, 2023
View reviewed changes
homeassistant/components/nibe_heatpump/__init__.py
@@ -329,18 +330,17 @@ def available(self) -> bool:
self.coordinator.data or {}
)

def _async_read_coil(self, coil: Coil):
def _async_read_coil(self, data: CoilData):
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Side note: Missing return value type annotation.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Right. Will fix in followup.

@MartinHjelmare
Copy link
Member

Tag for beta?

@elupus elupus added this to the 2023.3.0 milestone Feb 26, 2023
@elupus elupus merged commit e00ff54 into home-assistant:dev Feb 26, 2023
@elupus elupus deleted the nibe/2.0.0 branch February 26, 2023 10:05
neugartf pushed a commit to neugartf/core that referenced this pull request Feb 26, 2023
@elupus @neugartf
Update nibe library to 2.0.0 (home-assistant#88769)
16bc5e6
balloob pushed a commit that referenced this pull request Feb 27, 2023
@elupus @balloob
Update nibe library to 2.0.0 (#88769)
8c7b29d
@github-actions github-actions bot locked and limited conversation to collaborators Feb 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MartinHjelmare MartinHjelmare MartinHjelmare approved these changes

Assignees
No one assigned
Labels
bugfix by-code-owner cherry-picked cla-signed dependency has-tests integration: nibe_heatpump Quality Scale: No score
Projects
None yet
Milestone
2023.3.0
Development

Successfully merging this pull request may close these issues.

Pool temperature sensor not available
3 participants
@elupus @MartinHjelmare @balloob