Do not block on reolink firmware check fail

[starkillerOG]

Breaking change

Proposed change

If Reolink camera WAN blocked (only local control, for privacy reasons), online firmware check will of course fail and raise a API error wich will be caught and re-raised as UpdateFailed and the entity will be marked as unavailable.
However this would prevent the integration from setting up since you would end up in a loop of ConfigEntryNotReady.

This PR will make sure the UpdateFailed will not result in a ConfigEntryNotReady for the online firmware check.

Type of change

• Dependency upgrade
• Bugfix (non-breaking change which fixes an issue)
• New integration (thank you!)
• New feature (which adds functionality to an existing integration)
• Deprecation (breaking change to happen in the future)
• Breaking change (fix/feature causing existing functionality to break)
• Code quality improvements to existing code or addition of tests

Additional information

• This PR fixes or closes issue: fixes #Error checking Reolink firmware update #88702
• This PR is related to issue:
• Link to documentation pull request:

Checklist

• The code change is tested and works locally.
• Local tests pass. Your PR cannot be merged unless tests pass
• There is no commented out code in this PR.
• I have followed the development checklist
• The code has been formatted using Black (black --fast homeassistant tests)
• Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

• Documentation added/updated for www.home-assistant.io

If the code communicates with devices, web services, or third-party tools:

• The manifest file has all fields filled out correctly.
  Updated and included derived files by running: python3 -m script.hassfest.
• New or updated dependencies have been added to requirements_all.txt.
  Updated by running python3 -m script.gen_requirements_all.
• For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
• Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

• I have reviewed two other open pull requests in this repository.

[starkillerOG]

Could this be added to the 2023.3.0 milestone?

[MartinHjelmare]

Can we check this before we activate the firmware coordinator?

[starkillerOG]

Not really, the only way to check if WAN is blocked is just try out a command that needs WAN such as the check_new_firmware command and the API will respond with "rspCode" : -17, "detail" : "rcv failed",.
However I have seen this rcv failed error before, also when you have a bad wifi connection to the camera or other issues.

[MartinHjelmare]

Ok. It's just a bit annoying that we need to log an error for a case where users have deliberately blocked WAN access.

[starkillerOG]

@MartinHjelmare I could remove the coordinator initial fetch from init.py and add a initial fetch to async_added_to_hass in the update entity. That way when the user disables the update entity because they blocked WAN, no more errors are logged.
What do you think of that?

[MartinHjelmare]

The coordinator is meant to fetch data for more than a single entity. Fetching data from the entity isn't in line with the coordinator architecture. If there's a single entity for the data source we don't really need a coordinator.