Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add active_child_template to universal media player #88816

Merged
merged 7 commits into from Jun 28, 2023

Conversation

Drafteed
Copy link
Contributor

@Drafteed Drafteed commented Feb 27, 2023

Proposed change

The universal media player itself selects active child media player based on a sorted list of states (#68036), which may not always be suitable for a some tasks. This change adds a new parameter active_child_template that will allow to select (override) active child based on the template.

Basic example:

media_player:
  - platform: universal
    name: sony_tv
    children:
      - media_player.sony_tv_cast
      - media_player.sony_tv_psk
    active_child_template: >
      {% if is_state_attr('media_player.sony_tv_cast', 'app_name', 'TV') %}
         media_player.sony_tv_psk
      {% else %}
         media_player.sony_tv_cast
      {% endif %}

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Member

@bieniu bieniu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good 👍

@bieniu bieniu added the smash Indicator this PR is close to finish for merging or closing label Jun 27, 2023
@emontnemery emontnemery changed the title Add active_children_template in universal Add active_children_template to universal media player Jun 28, 2023
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The name of the new parameter, active_children_template suggests plural, but the documentation suggests singular, i.e. a single active child:

Template must return the entity_id of the child that will be selected as active

@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft June 28, 2023 08:51
@emontnemery emontnemery removed the smash Indicator this PR is close to finish for merging or closing label Jun 28, 2023
@Drafteed Drafteed changed the title Add active_children_template to universal media player Add active_child_template to universal media player Jun 28, 2023
@Drafteed Drafteed marked this pull request as ready for review June 28, 2023 11:43
Copy link
Contributor

@emontnemery emontnemery left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Drafteed 👍

@emontnemery emontnemery merged commit c14a2dd into home-assistant:dev Jun 28, 2023
23 checks passed
@Drafteed Drafteed deleted the universal-children-template branch June 28, 2023 14:39
@github-actions github-actions bot locked and limited conversation to collaborators Jun 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants