-
-
Notifications
You must be signed in to change notification settings - Fork 28.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add active_child_template
to universal media player
#88816
Add active_child_template
to universal media player
#88816
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good 👍
active_children_template
in universalactive_children_template
to universal media player
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The name of the new parameter, active_children_template
suggests plural, but the documentation suggests singular, i.e. a single active child:
Template must return the
entity_id
of the child that will be selected as active
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
active_children_template
to universal media playeractive_child_template
to universal media player
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks @Drafteed 👍
Proposed change
The universal media player itself selects active child media player based on a sorted list of states (#68036), which may not always be suitable for a some tasks. This change adds a new parameter
active_child_template
that will allow to select (override) active child based on the template.Basic example:
Type of change
Additional information
active_child_template
to universal media player home-assistant.io#26377Checklist
black --fast homeassistant tests
)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest
.requirements_all.txt
.Updated by running
python3 -m script.gen_requirements_all
..coveragerc
.To help with the load of incoming pull requests: