Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump gios library to version 3.1.0 #89044

Merged
merged 3 commits into from Mar 6, 2023
Merged

Bump gios library to version 3.1.0 #89044

merged 3 commits into from Mar 6, 2023

Conversation

bieniu
Copy link
Member

@bieniu bieniu commented Mar 2, 2023 •
edited

Breaking change

AQI sensor state values are now in English, and the user interface will display their translation for the selected language.

Users should update their automations and scripts.

Proposed change

What's changed:

  • library bumps to version 3.1.0
  • AQI sensor state values are now in English
  • AQI sensor uses SensorDeviceClass.ENUM device class

In the next step, I plan to migrate index sensor state attributes to the separate entities and remove name and station attributes because they present static data.

Changelog: bieniu/gios@2.3.0...3.1.0

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Mar 5, 2023
frenck
frenck requested changes Mar 6, 2023
View reviewed changes
tests/components/gios/test_sensor.py
@@ -50,7 +51,7 @@ async def test_sensor(hass: HomeAssistant) -> None:
== CONCENTRATION_MICROGRAMS_PER_CUBIC_METER
)
assert state.attributes.get(ATTR_ICON) == "mdi:molecule"
assert state.attributes.get(ATTR_INDEX) == "bardzo dobry"
assert state.attributes.get(ATTR_INDEX) == "very_good"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You can also provide translations for attributes in our strings.json file.

https://developers.home-assistant.io/docs/internationalization/core#entity-state-attributes

Although the frontend currently only supports climate right now, it would be a matter of time before the rest is implemented. The backend supports it fully.

Copy link
Member Author

@bieniu bieniu Mar 6, 2023 •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I plan to migrate index attributes to the separate entities in the next step. Do you think the attributes will be better? And I want to remove name and station attributes because they present static data.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm always all in favor of less attributes 🎉 😬

@home-assistant home-assistant bot marked this pull request as draft March 6, 2023 16:55
@home-assistant
Copy link

home-assistant bot commented Mar 6, 2023

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@frenck frenck marked this pull request as ready for review March 6, 2023 17:11
@home-assistant home-assistant bot requested a review from frenck March 6, 2023 17:11
frenck
frenck approved these changes Mar 6, 2023
View reviewed changes
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @bieniu 👍

../Frenck

@frenck frenck merged commit 1538f63 into home-assistant:dev Mar 6, 2023
@bieniu bieniu deleted the bump-gios branch March 6, 2023 18:36
@github-actions github-actions bot locked and limited conversation to collaborators Mar 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@frenck frenck frenck approved these changes

Assignees
No one assigned
Labels
breaking-change by-code-owner cla-signed dependency has-tests integration: gios Quality Scale: platinum small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@bieniu @frenck