Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update mypy to 1.1.1 #89268

Merged
merged 4 commits into from
Mar 8, 2023
Merged

Update mypy to 1.1.1 #89268

merged 4 commits into from
Mar 8, 2023

Conversation

cdce8p
Copy link
Member

@cdce8p cdce8p commented Mar 7, 2023

Proposed change

Release notes: https://mypy-lang.blogspot.com/2023/03/mypy-111-released.html

Smaller update. The main new feature is support for the dataclass_transform decorator.
Unfortunately, this breaks the pydantic plugin currently. I've already opened a PR to fix it upstream - waiting for a new release.

--
Edit: Update pydantic to 1.10.6
Release notes: https://github.com/pydantic/pydantic/releases/tag/v1.10.6
Compare view: pydantic/pydantic@v1.10.5...v1.10.6

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Mar 7, 2023

Hey there @home-assistant/core, mind taking a look at this pull request as it has been labeled with an integration (http) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of http can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign http Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@home-assistant
Copy link

home-assistant bot commented Mar 7, 2023

Hey there @home-assistant/z-wave, mind taking a look at this pull request as it has been labeled with an integration (zwave_js) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zwave_js can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign zwave_js Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@home-assistant
Copy link

home-assistant bot commented Mar 7, 2023

Hey there @home-assistant/matter, mind taking a look at this pull request as it has been labeled with an integration (matter) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of matter can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign matter Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@home-assistant
Copy link

home-assistant bot commented Mar 7, 2023

Hey there @bdraco, mind taking a look at this pull request as it has been labeled with an integration (zeroconf) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of zeroconf can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign zeroconf Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@home-assistant
Copy link

home-assistant bot commented Mar 7, 2023

Hey there @klaasnicolaas, mind taking a look at this pull request as it has been labeled with an integration (p1_monitor) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of p1_monitor can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign p1_monitor Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@cdce8p cdce8p added the waiting-for-upstream We're waiting for a change upstream label Mar 7, 2023
@cdce8p cdce8p removed the waiting-for-upstream We're waiting for a change upstream label Mar 8, 2023
@cdce8p cdce8p marked this pull request as ready for review March 8, 2023 21:24
@cdce8p cdce8p requested review from a team and bdraco as code owners March 8, 2023 21:24
@cdce8p cdce8p requested review from a team as code owners March 8, 2023 21:24
@cdce8p cdce8p merged commit 386533a into home-assistant:dev Mar 8, 2023
@cdce8p cdce8p deleted the update-mypy branch March 8, 2023 21:57
@github-actions github-actions bot locked and limited conversation to collaborators Mar 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants