Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bump ruff to 0.0.254 #89273

Merged
merged 5 commits into from
Mar 7, 2023
Merged

Bump ruff to 0.0.254 #89273

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
1ae47ba
Bump ruff to 0.0.254
epenet Mar 7, 2023
65a884a
Fix UP038
epenet Mar 7, 2023
6f4b668
Fix D417
epenet Mar 7, 2023
30d8dcb
Revert "Fix UP038"
epenet Mar 7, 2023
f9c7070
Add UP038 to ignore list
epenet Mar 7, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .pre-commit-config.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
repos:
- repo: https://github.com/charliermarsh/ruff-pre-commit
rev: v0.0.253
rev: v0.0.254
hooks:
- id: ruff
args:
Expand Down
2 changes: 2 additions & 0 deletions homeassistant/components/esphome/bluetooth/client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -526,6 +526,7 @@ async def read_gatt_char(
The characteristic to read from, specified by either integer
handle, UUID or directly by the BleakGATTCharacteristic
object representing it.
**kwargs: Unused
Copy link
Contributor Author

@epenet epenet Mar 7, 2023 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This file resolves D417 Missing argument description in the docstring
All others refer to UP038 [*] Use 'X | Y' in 'isinstance' call instead of '(X, Y)'


Returns:
(bytearray) The read data.
Expand All @@ -542,6 +543,7 @@ async def read_gatt_descriptor(self, handle: int, **kwargs: Any) -> bytearray:

Args:
handle (int): The handle of the descriptor to read from.
**kwargs: Unused

Returns:
(bytearray) The read data.
Expand Down
2 changes: 2 additions & 0 deletions pyproject.toml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -272,6 +272,8 @@ ignore = [
"D407", # Section name underlining
"E501", # line too long
"E731", # do not assign a lambda expression, use a def
# Ignored due to performance: https://github.com/charliermarsh/ruff/issues/2923
"UP038", # Use `X | Y` in `isinstance` call instead of `(X, Y)`
]

[tool.ruff.flake8-import-conventions.extend-aliases]
Expand Down
2 changes: 1 addition & 1 deletion requirements_test_pre_commit.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -14,5 +14,5 @@ pycodestyle==2.10.0
pydocstyle==6.2.3
pyflakes==3.0.1
pyupgrade==3.3.1
ruff==0.0.253
ruff==0.0.254
yamllint==1.28.0