Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct missing wordswap for S series nibe #89866

Merged
merged 1 commit into from Mar 20, 2023
Merged

Correct missing wordswap for S series nibe #89866

merged 1 commit into from Mar 20, 2023

Conversation

elupus
Copy link
Contributor

@elupus elupus commented Mar 17, 2023

Correct missing wordswap for nibe

Proposed change

Make sure word swap is set for S series pumps too.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Correct missing wordswap for nibe
@elupus elupus marked this pull request as ready for review March 18, 2023 10:50
@elupus elupus added this to the 2023.3.6 milestone Mar 18, 2023
@elupus elupus enabled auto-merge (squash) March 18, 2023 10:51
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Mar 20, 2023
Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @elupus 👍

../Frenck

@elupus elupus merged commit 9f1e170 into dev Mar 20, 2023
24 checks passed
@elupus elupus deleted the elupus-patch-1 branch March 20, 2023 11:08
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix by-code-owner cherry-picked cla-signed integration: nibe_heatpump Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Nibe integration broken after Release 2023.3.5
3 participants