Add Landis+Gyr MWh-readings from ultraheat-api #89937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vpathuis
changed the title
epenet
reviewed
Mar 22, 2023
epenet
requested changes
Mar 22, 2023
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
epenet
reviewed
Mar 22, 2023
20 tasks
epenet
reviewed
Mar 23, 2023
epenet
reviewed
Mar 23, 2023
epenet
reviewed
Mar 23, 2023
epenet
reviewed
Mar 23, 2023
Remove manifest cleanup from PR Remove added device class from this PR Restore entity registry fixture Replace filter by attr_entity_registry_enabled_default
|
It's great to seeing this progress but apparently this PR isn't merged jet. does that imply that the T550 model will not be supported with the next release of HA? |
epenet
added
the
smash
The merge window for Home Assistant core 2023.4 closed just yesterday, so this will be included in Home Assistant core 2023.5 |
epenet
reviewed
Mar 30, 2023
| native_unit_of_measurement=UnitOfEnergy.MEGA_WATT_HOUR, | ||
| device_class=SensorDeviceClass.ENERGY, | ||
| state_class=SensorStateClass.TOTAL, | ||
| value_fn=lambda res: getattr(res, "heat_usage_mwh", None), |
There was a problem hiding this comment.
In a follow-up PR, I think you should remove all the getattr.
value_fn=lambda res: res.heat_usage_mwh,
value_fn=lambda res: res.volume_usage_m3,
...
value_fn=lambda res: res.settings_and_firmware,
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
This change adds support for the T550 model by reading MWh-values whenever supplied by the ultraheat-api.
Type of change
Additional information
This PR fixes or closes issue: fixes
Landis+Gyr Heat Meter - Update for sensor.heat_meter_heat_usage_gj fails #81464
Landis+Gyr Heat Meter not working with meters that report mwh #85548
Landis+Gyr Heat Meter Info not showing data #84130
Support for Landis+Gyr UltraHeat T550 vpathuis/ultraheat#7
Landis+Gyr Heat Meter - Update for sensor.heat_meter_heat_usage_gj fails #81464
Landis+Gyr Heat Meter fails to collect data #85012
sensor.heat_meter_heat_usage_gj as gas source resulting in Unexpected device class & Unexpected state class warnings #86545
This PR is related to issue:
Link to documentation pull request:
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: