Use SnapshotAssertion in bmw_connected_drive tests #90128
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
home-assistant
bot
added
cla-signed
code-quality
has-tests
integration: bmw_connected_drive
small-pr
|
Hey there @gerard33, mind taking a look at this pull request as it has been labeled with an integration ( Code owner commandsCode owners of
|
This was referenced Mar 22, 2023
frenck
added
the
smash
|
Needs to be rebased over #90127 |
epenet
removed
the
smash
rikroe
force-pushed
the
bmw-snapshotassertion
branch
from
55d0949
to
0bb274e
Compare
|
Rebased and updated snapshot for new dependency version. |
frenck
requested changes
Mar 23, 2023
Comment on lines
30
to
32
|
|
||
| Could fail after every change (either to HA or the library). If so, regenerate using | ||
| pytest --snapshot-update tests/components/bmw_connected_drive/ and check the output. |
There was a problem hiding this comment.
I don't think this is the right place to document how snapshotting works 😉
There was a problem hiding this comment.
Removed. You're right, it was rather a convenience feature for myself to have it stored somewhere quickly available.
Comment on lines
57
to
58
| Could fail after every change (either to HA or the library). If so, regenerate using | ||
| pytest --snapshot-update tests/components/bmw_connected_drive/ and check the output. |
Comment on lines
89
to
90
| Could fail after every change (either to HA or the library). If so, regenerate using | ||
| pytest --snapshot-update tests/components/bmw_connected_drive/ and check the output. |
|
Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍 |
epenet
added
the
smash
frenck
approved these changes
Mar 26, 2023
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Proposed change
As requested in #88759 (comment), this PR implements
SnapshotAssertionfor BMW Connected Drive diagnostic tests in a separate PR.Depending if this or #90127 gets merged first, the other PR will need a quick refactoring due to changing fixtures/diagnostic snapshots.
Type of change
Additional information
Checklist
black --fast homeassistant tests)If user exposed functionality or configuration variables are added/changed:
If the code communicates with devices, web services, or third-party tools:
Updated and included derived files by running:
python3 -m script.hassfest.requirements_all.txt.Updated by running
python3 -m script.gen_requirements_all..coveragerc.To help with the load of incoming pull requests: