Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Improve airq test coverage #90192

Merged
merged 3 commits into from Mar 28, 2023
Merged

Improve airq test coverage #90192

merged 3 commits into from Mar 28, 2023

Conversation

Sibgatulin
Copy link
Contributor

Test that the integration setup aborts with "already_configured" reason when the integration has already been configured.

Breaking change

Proposed change

@MartinHjelmare pointed out that such a test was missing.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @dl2080, mind taking a look at this pull request as it has been labeled with an integration (airq) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of airq can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign airq Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@epenet epenet changed the title Add a missing test for aborting with "already_configured" Improve airq coverage Mar 23, 2023
@epenet epenet changed the title Improve airq coverage Improve airq test coverage Mar 23, 2023
davet2001
davet2001 approved these changes Mar 24, 2023
View reviewed changes
Copy link
Contributor

@davet2001 davet2001 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me!

epenet
epenet requested changes Mar 24, 2023
View reviewed changes
tests/components/airq/test_config_flow.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft March 24, 2023 06:59
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@Sibgatulin Sibgatulin mentioned this pull request Mar 24, 2023
Merged
20 tasks
@Sibgatulin
Copy link
Contributor Author

Thanks for looking into it @davet2001

@Sibgatulin
Add a missing test for aborting with "already_configured"
d0a8f49 
Test that config_flow aborts with "already_configured" when the
integration has already been configured
@Sibgatulin
Don't copy test data
dda5557 
Since home-assistant#90232 is merged, it is no longer needed
epenet
epenet approved these changes Mar 28, 2023
View reviewed changes
Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@Sibgatulin Sibgatulin marked this pull request as ready for review March 28, 2023 12:56
@home-assistant home-assistant bot requested a review from epenet March 28, 2023 12:56
@epenet epenet merged commit 091932c into home-assistant:dev Mar 28, 2023
26 checks passed
@Sibgatulin Sibgatulin deleted the air_q-test_duplicate_config branch March 28, 2023 13:04
@github-actions github-actions bot locked and limited conversation to collaborators Mar 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@davet2001 davet2001 davet2001 approved these changes

@epenet epenet Awaiting requested review from epenet

Assignees
No one assigned
Labels
by-code-owner cla-signed code-quality has-tests integration: airq Quality Scale: No score small-pr PRs with less than 30 lines.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@Sibgatulin @epenet @davet2001