Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add livisi window sensor (WDS) #90220

Merged
merged 36 commits into from Mar 24, 2023
Merged

Add livisi window sensor (WDS) #90220

merged 36 commits into from Mar 24, 2023

Conversation

planbnet
Copy link
Contributor

Breaking change

Proposed change

Add support for Livisi Window Door Sensors (WDS) as binary_sensor

Taken over from #82659 (now closed because original author lost interest). I have updated the code to current code structure and implemented all suggested changes from the review there.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @StefanIacobLivisi, mind taking a look at this pull request as it has been labeled with an integration (livisi) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of livisi can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign livisi Removes the current integration label and assignees on the pull request, add the integration domain after the command.

homeassistant/components/livisi/coordinator.py Outdated Show resolved Hide resolved
homeassistant/components/livisi/coordinator.py Outdated Show resolved Hide resolved
@home-assistant
Copy link

Please take a look at the requested changes, and use the Ready for review button when you are done, thanks 👍

Learn more about our pull request process.

@home-assistant home-assistant bot marked this pull request as draft March 24, 2023 08:39
@planbnet planbnet marked this pull request as ready for review March 24, 2023 12:06
@home-assistant home-assistant bot requested a review from epenet March 24, 2023 12:06
homeassistant/components/livisi/binary_sensor.py Outdated Show resolved Hide resolved
homeassistant/components/livisi/coordinator.py Outdated Show resolved Hide resolved
.coveragerc Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft March 24, 2023 12:19
planbnet and others added 3 commits March 24, 2023 13:30
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
@planbnet
Copy link
Contributor Author

Maybe we can merge this PR in the current state without the tests (see my reply in the review comment)? I took over the original PR ( #82659 ) because people in the Livisi forum are eagerly waiting for this...

@planbnet planbnet marked this pull request as ready for review March 24, 2023 13:10
@home-assistant home-assistant bot requested a review from epenet March 24, 2023 13:10
Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oups - just spotted one small thing.

homeassistant/components/livisi/binary_sensor.py Outdated Show resolved Hide resolved
homeassistant/components/livisi/binary_sensor.py Outdated Show resolved Hide resolved
@home-assistant home-assistant bot marked this pull request as draft March 24, 2023 13:30
planbnet and others added 3 commits March 24, 2023 14:34
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
Co-authored-by: epenet <6771947+epenet@users.noreply.github.com>
@planbnet planbnet marked this pull request as ready for review March 24, 2023 13:35
@home-assistant home-assistant bot requested a review from epenet March 24, 2023 13:35
Copy link
Contributor

@epenet epenet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@epenet epenet merged commit 0bb0b4b into home-assistant:dev Mar 24, 2023
26 checks passed
@planbnet planbnet deleted the wds branch March 24, 2023 15:09
@github-actions github-actions bot locked and limited conversation to collaborators Mar 25, 2023
@frenck frenck added the noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) label Mar 28, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
by-code-owner cla-signed integration: livisi new-feature new-platform noteworthy Marks a PR as noteworthy and should be in the release notes (in case it normally would not appear) Quality Scale: No score
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants