Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Reolink doorbell extend features #90469

Merged
merged 6 commits into from
Apr 22, 2023
Merged

Reolink doorbell extend features #90469

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
5f57965
Extend options for doorbell status led
starkillerOG Mar 29, 2023
76ff9fe
Add doorbell button sound
starkillerOG Mar 29, 2023
8800a2b
Add translation
starkillerOG Mar 29, 2023
99cb0cd
styling
starkillerOG Mar 29, 2023
3d36338
fix status led
starkillerOG Mar 29, 2023
2c3a879
Merge branch 'dev' into reolink_doorbell_extend
starkillerOG Mar 29, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion homeassistant/components/reolink/light.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -66,7 +66,7 @@ class ReolinkLightEntityDescription(
name="Status LED",
icon="mdi:lightning-bolt-circle",
entity_category=EntityCategory.CONFIG,
supported_fn=lambda api, ch: api.supported(ch, "status_led"),
supported_fn=lambda api, ch: api.supported(ch, "power_led"),
is_on_fn=lambda api, ch: api.status_led_enabled(ch),
turn_on_off_fn=lambda api, ch, value: api.set_status_led(ch, value),
),
Expand Down
19 changes: 18 additions & 1 deletion homeassistant/components/reolink/select.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,13 @@
from dataclasses import dataclass
from typing import Any

from reolink_aio.api import DayNightEnum, Host, SpotlightModeEnum, TrackMethodEnum
from reolink_aio.api import (
DayNightEnum,
Host,
SpotlightModeEnum,
StatusLedEnum,
TrackMethodEnum,
)

from homeassistant.components.select import SelectEntity, SelectEntityDescription
from homeassistant.config_entries import ConfigEntry
Expand Down Expand Up @@ -90,6 +96,17 @@ class ReolinkSelectEntityDescription(
value=lambda api, ch: TrackMethodEnum(api.auto_track_method(ch)).name,
method=lambda api, ch, name: api.set_auto_tracking(ch, method=name),
),
ReolinkSelectEntityDescription(
key="status_led",
name="Status LED",
icon="mdi:lightning-bolt-circle",
translation_key="status_led",
entity_category=EntityCategory.CONFIG,
get_options=[state.name for state in StatusLedEnum],
supported=lambda api, ch: api.supported(ch, "doorbell_led"),
value=lambda api, ch: StatusLedEnum(api.doorbell_led(ch)).name,
method=lambda api, ch, name: api.set_status_led(ch, StatusLedEnum[name].value),
),
)


Expand Down
7 changes: 7 additions & 0 deletions homeassistant/components/reolink/strings.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -83,6 +83,13 @@
"digitalfirst": "Digital first",
"pantiltfirst": "Pan/tilt first"
}
},
"status_led": {
"state": {
"stayoff": "Stay off",
"auto": "Auto",
"alwaysonatnight": "Auto & always on at night"
}
}
}
}
Expand Down
9 changes: 9 additions & 0 deletions homeassistant/components/reolink/switch.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -98,6 +98,15 @@ class ReolinkNVRSwitchEntityDescription(
value=lambda api, ch: api.ptz_guard_enabled(ch),
method=lambda api, ch, value: api.set_ptz_guard(ch, enable=value),
),
ReolinkSwitchEntityDescription(
key="doorbell_button_sound",
name="Doorbell button sound",
icon="mdi:volume-high",
entity_category=EntityCategory.CONFIG,
supported=lambda api, ch: api.supported(ch, "doorbell_button_sound"),
value=lambda api, ch: api.doorbell_button_sound(ch),
method=lambda api, ch, value: api.set_volume(ch, doorbell_button_sound=value),
),
)

NVR_SWITCH_ENTITIES = (
Expand Down