Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reolink doorbell extend features #90469

Merged
merged 6 commits into from Apr 22, 2023

Conversation

starkillerOG
Copy link
Contributor

@starkillerOG starkillerOG commented Mar 29, 2023

Breaking change

For Reolink doorbells, the "Status LED" light entity is replaced by a "Status LED" select entity, the entity_id domain is therefore changed. The switch off state corresponds to the select Auto, and the swith on state corresponds to the select Auto & always on at night. A additional Stay off state is now available.

Proposed change

Extend the reolink doorbell features:

  • A "Doorbell button sound" switch to turn on/off the sound the doorbell makes when it is pressed.
  • For Doorbells, change the "Status LED" light entity to a select entity that offers options: Stay off, Auto and Auto & always on at night, Stay off: The LED ring on the doorbell is always off, Auto: When a person is detected by the doorbell the LED ring will pulsate like a heartbeat, Auto & always on at night: When the camera is in night mode the LED Ring is constant on, during day and night, the LED ring will pulsate like a heartbeat when a person is detected.

Note that the status LED used to be a switch in the Reolink app, the recent firmware update of the doorbell changed this to a drop-down menu with 3 options.

Requires #90467 to be merged first.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@starkillerOG starkillerOG marked this pull request as ready for review March 29, 2023 22:11
@starkillerOG
Copy link
Contributor Author

starkillerOG commented Mar 29, 2023

The "Status LED" light entity is currently in the 2023.04 beta release, so if this gets merged in beta the change to a select entity would not be a breaking change.
If it is for 2023.05, this will be a breaking change.

@starkillerOG
Copy link
Contributor Author

Could someone add the breaking-change tag?

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @starkillerOG 👍

@frenck frenck merged commit 8544d73 into home-assistant:dev Apr 22, 2023
21 checks passed
joanwa pushed a commit to joanwa/home-assistant that referenced this pull request Apr 23, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants