Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reolink autotrack streams for TrackMix and high/low resolution snapshots #90591

Merged
merged 9 commits into from May 31, 2023

Conversation

starkillerOG
Copy link
Contributor

@starkillerOG starkillerOG commented Mar 31, 2023

Breaking change

Proposed change

Add autotracking streams for the second lens of TrackMix series camera's when they are connected directly to a NVR.
(These streams are already available in HA when connecting the TrackMix directly to HomeAsssitant).

Before all snapshots were high resolution, now the sub stream uses low resolution snapshots and the main stream uses high resolution snapshots. In this way the snapshot resolution is the same as the stream resolution
The "snapshots" camera entity (high res) has been split into "snapshots main" (high res) and "snapshots sub" (low res).
Both are disabled by default.

Requires PR #90590 to be merged first

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@starkillerOG

This comment was marked as off-topic.

@starkillerOG starkillerOG added the smash Indicator this PR is close to finish for merging or closing label May 12, 2023
@balloob balloob merged commit b91c691 into home-assistant:dev May 31, 2023
24 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Jun 1, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bugfix by-code-owner cla-signed integration: reolink new-feature Quality Scale: No score small-pr PRs with less than 30 lines. smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reolink sub stream capturing snapshots from main stream
2 participants