Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade dwd_weather_warnings dependency dwdwfsapi to 1.0.6 #90683

Merged
merged 2 commits into from Apr 3, 2023

Conversation

andarotajo
Copy link
Contributor

Proposed change

This PR upgrades the dwdwfsapi dependency for dwd_weather_warnings to 1.0.6. This is split off from #79944 and was requested due to the amount of different changes put in the mentioned PR. The new version allows the usage of GPS coordinates (latitude & longitude) which is needed for my intended change.

The changelog for the specified version can be found here

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Apr 2, 2023

Hey there @runningman84, @stephan192, @hummel95, mind taking a look at this pull request as it has been labeled with an integration (dwd_weather_warnings) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of dwd_weather_warnings can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign dwd_weather_warnings Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@andarotajo
Copy link
Contributor Author

@cgarwood Not sure about the process, but am I allowed to merge this now that you've approved the changes?

Copy link
Member

@frenck frenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @andarotajo 👍

../Frenck

@frenck frenck merged commit 37556a5 into home-assistant:dev Apr 3, 2023
52 checks passed
@andarotajo andarotajo deleted the dwd_upgrade_dependency branch April 3, 2023 09:16
@github-actions github-actions bot locked and limited conversation to collaborators Apr 4, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants