Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump aioambient to 2023.04.0 #90991

Merged
merged 4 commits into from Apr 7, 2023
Merged

Bump aioambient to 2023.04.0 #90991

merged 4 commits into from Apr 7, 2023

Conversation

bachya
Copy link
Contributor

@bachya bachya commented Apr 7, 2023

Proposed change

Changelog: https://github.com/bachya/aioambient/releases/tag/2023.04.0
Diff: bachya/aioambient@2022.10.0...2023.04.0 (don't be put off by how large the diff is—it's mostly dependency bumps)

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: N/A
  • This PR is related to issue: N/A
  • Link to documentation pull request: N/A

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

Copy link
Contributor

@allenporter allenporter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Library diff all looks good, assuming CI passes

@bdraco bdraco added this to the 2023.4.2 milestone Apr 7, 2023
@bdraco
Copy link
Member

bdraco commented Apr 7, 2023

I'll fix the pip check chicken-egg issue by bumping the conflicts in the other PR, merging it, than taking the conflict back out in this PR

@bdraco bdraco mentioned this pull request Apr 7, 2023
23 tasks
@bdraco
Copy link
Member

bdraco commented Apr 7, 2023

Thanks @bachya

@bdraco bdraco merged commit 175f38b into home-assistant:dev Apr 7, 2023
54 checks passed
@github-actions github-actions bot locked and limited conversation to collaborators Apr 8, 2023
@bachya bachya deleted the ambient-bump branch April 10, 2023 20:54
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants