Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix false positive in SQL sensor full table scan check #91134

Merged
merged 2 commits into from
Apr 10, 2023

Conversation

bdraco
Copy link
Member

@bdraco bdraco commented Apr 9, 2023

Proposed change

Fix false positive in SQL sensor full table scan check. It was reported that this check unexpected matched a custom view called view_sensor_db_unique_entity_ids.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

  • This PR fixes or closes issue: fixes #
  • This PR is related to issue:
  • Link to documentation pull request:

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

home-assistant bot commented Apr 9, 2023

Hey there @dgomes, @gjohansson-ST, mind taking a look at this pull request as it has been labeled with an integration (sql) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of sql can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign sql Removes the current integration label and assignees on the pull request, add the integration domain after the command.

@cgarwood
Copy link
Member

cgarwood commented Apr 9, 2023

Looks like this won't catch if you're selecting more than just the entity_id column? SELECT entity_id,other_column,etc from states?

@bdraco
Copy link
Member Author

bdraco commented Apr 9, 2023

Looks like this won't catch if you're selecting more than just the entity_id column? SELECT entity_id,other_column,etc from states?

good call we should do , as well

@bdraco
Copy link
Member Author

bdraco commented Apr 9, 2023

adjusted in 34230c7

@teskanoo
Copy link

Thanks to all who helped to address this.

@bdraco bdraco merged commit 6e9fcbf into dev Apr 10, 2023
@bdraco bdraco deleted the sql_sensor_false_positive branch April 10, 2023 05:45
@bdraco
Copy link
Member Author

bdraco commented Apr 10, 2023

Thanks!

@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants