Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reolink config flow fix custom port when USE_HTTPS not selected #91137

Merged
merged 1 commit into from
Apr 10, 2023

Conversation

starkillerOG
Copy link
Contributor

@starkillerOG starkillerOG commented Apr 9, 2023

Breaking change

Proposed change

When a user has configured a non-default port on the Reolink camera (besides port 80 and 443), the user needs to supply both the port and if HTTPS will be used. If only 1 of the two are given, they will be ignored and the default ports 80 and 443 will be used.

Currently the config flow form does not clearly show a "optional" boolean box, so it apears to be just off, however when the user does not press the USE_HTTPS box, the value will be None and even if they supplyed a port, it will not be used.

This PR makes sure USE_HTTPS box will always have a true/false value, so if a user puts in a port it will be used, if they leave the port empty, the default ports will be used.

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@starkillerOG starkillerOG changed the title give USE_HTTPS a default Reolink config flow fix custom port when USE_HTTPS not selected Apr 9, 2023
@starkillerOG
Copy link
Contributor Author

Could this be added to the 2023.4.3 milestone?

@balloob balloob merged commit e814298 into home-assistant:dev Apr 10, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Apr 11, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reolink dont accept Port setting for connection
3 participants